[
https://issues.apache.org/jira/browse/CASSANDRA-17964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17680206#comment-17680206
]
Stefan Miklosovic commented on CASSANDRA-17964:
-----------------------------------------------
[~mck] I find your input valuable here, to save you from going through this I
will summarize.
This patch introduces an Ant task which will check that test classes end on
"Test" and it will fail the build when not all of them are. When we renamed the
tests which did not end on "Tests" to pass the check, some of tests, when
committed and run in CI will start to fail. They were failing before as well,
but because of their name, they were never picked up by CI so their failure
went undetected.
We were suggesting to Ignore these tests (put Ignore annotation on top of them)
with description why and we create new ticket(s) to fix them. This solution
will not mark these tests as erroneous but they will not be run.
Another solution is to keep them un-ignored but they would start to appear in
the results as constantly failing.
The tests we are talking about are (both in long test suite)
org.apache.cassandra.cql3.GcCompactionBench
org.apache.cassandra.cql3.CachingBench
I would slightly prefer just ignoring them, mostly because they are long tests
and they eat resources absolutely unnecessarily when they fail every time. I
agree with David who said:
_The *Bench tests will fail 100% of the time in CI... I am in trunk and ran
GcCompactionBench, each test takes 1m (will be slower in CI) and each fails...
This will have the side effect of adding failing tests and causing the JVM to
timeout due to our unit test limit being smaller than the runtime of these
tests._
> Some tests are never executed due to naming violation - fix it and add
> checkstyle where applicable
> --------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-17964
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17964
> Project: Cassandra
> Issue Type: Task
> Components: Test/unit
> Reporter: Ruslan Fomkin
> Assignee: Stefan Miklosovic
> Priority: Normal
> Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1.x, 4.x
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> [BatchTests|https://github.com/apache/cassandra/blob/trunk/test/unit/org/apache/cassandra/cql3/BatchTests.java]
> doesn't follow naming convention to be run as unit tests and, thus, is never
> run.
> The rule in build expects names as `*Test`.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
