[
https://issues.apache.org/jira/browse/CASSANDRA-18001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17681124#comment-17681124
]
Ekaterina Dimitrova edited comment on CASSANDRA-18001 at 1/27/23 2:12 AM:
--------------------------------------------------------------------------
{quote}I have also commented a couple of typos on [the
commit|https://github.com/ekaterinadimitrova2/cassandra/commit/514e07dfee300b1b972e860c2f61674fae0793c6].
{quote}
Thank you for spotting those, I will fix them
{quote}Just one nit, I think that in the pre-commit workflow the jobs for large
dtests should share a single approval button. That button would approve regular
and repeated large dtests, possibly with and without vnodes. That would
simplify the workflow of the pre-commit workflow, while we still have the
separate workflow for fine tuning.
{quote}
We can do that. It was done that way in 4.1 and trunk so we will have to change
it there too. The only thing maybe is that those are resource intensive and I
think that's why we kept them separate
You actually also reminded me I should also add config to test the repeated
runs jobs for the Python large DTests (we do not have for the cqlshlib)
was (Author: e.dimitrova):
{quote}I have also commented a couple of typos on [the
commit|https://github.com/ekaterinadimitrova2/cassandra/commit/514e07dfee300b1b972e860c2f61674fae0793c6].
{quote}
Thank you for spotting those, I will fix them
{quote}Just one nit, I think that in the pre-commit workflow the jobs for large
dtests should share a single approval button. That button would approve regular
and repeated large dtests, possibly with and without vnodes. That would
simplify the workflow of the pre-commit workflow, while we still have the
separate workflow for fine tuning.
{quote}
We can do that. It was done that way in 4.1 and trunk so we will have to change
it there too. The only thing maybe is that those are resource intensive and I
think that's why we kept them separate
You actually also reminded me I should add some test change to trigger the
testing also for the repeated runs jobs
> Add missing tests suites to CircleCI
> ------------------------------------
>
> Key: CASSANDRA-18001
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18001
> Project: Cassandra
> Issue Type: Task
> Components: CI
> Reporter: Ekaterina Dimitrova
> Assignee: Ekaterina Dimitrova
> Priority: Urgent
> Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1-rc1, 4.1, 4.1.x, 4.2, 4.x
>
>
> Burn tests to all branches, large Python DTests (with/without vnodes),
> cqlshlib not tested in all branches and with all jdks; Java distributed tests
> not running with J8/J11 4.0+
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
