[
https://issues.apache.org/jira/browse/CASSANDRA-1608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13087991#comment-13087991
]
Alan Liang edited comment on CASSANDRA-1608 at 8/19/11 9:34 PM:
----------------------------------------------------------------
There's a problem with Interval#intersects:
{code}
public boolean intersects(Interval interval)
{
return this.contains(interval.min) || this.contains(interval.min);
}
{code}
I think you wanted:
{code}
return this.contains(interval.min) || this.contains(interval.max);
{code}
However, a more efficient way to do this would be:
{code}
return this.min.compareTo(interval.max) <= 0 &&
this.max.compareTo(interval.min) >= 0;
{code}
was (Author: alanliang):
There's a problem with Interval#intersects:
{code}
public boolean intersects(Interval interval)
{
return this.contains(interval.min) || this.contains(interval.min);
}
{code}
I think you wanted:
{code}
return this.contains(interval.min) || this.contains(interval.max);
{code}
However, a more efficient way to do this would be:
{code}
return this.min.compareTo(interval.max) <= 0 && return
this.max.compareTo(interval.min) >= 0;
{code}
> Redesigned Compaction
> ---------------------
>
> Key: CASSANDRA-1608
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1608
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Chris Goffinet
> Assignee: Benjamin Coverston
> Attachments: 1608-v11.txt, 1608-v13.txt, 1608-v2.txt
>
>
> After seeing the I/O issues in CASSANDRA-1470, I've been doing some more
> thinking on this subject that I wanted to lay out.
> I propose we redo the concept of how compaction works in Cassandra. At the
> moment, compaction is kicked off based on a write access pattern, not read
> access pattern. In most cases, you want the opposite. You want to be able to
> track how well each SSTable is performing in the system. If we were to keep
> statistics in-memory of each SSTable, prioritize them based on most accessed,
> and bloom filter hit/miss ratios, we could intelligently group sstables that
> are being read most often and schedule them for compaction. We could also
> schedule lower priority maintenance on SSTable's not often accessed.
> I also propose we limit the size of each SSTable to a fix sized, that gives
> us the ability to better utilize our bloom filters in a predictable manner.
> At the moment after a certain size, the bloom filters become less reliable.
> This would also allow us to group data most accessed. Currently the size of
> an SSTable can grow to a point where large portions of the data might not
> actually be accessed as often.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
