[ 
https://issues.apache.org/jira/browse/CASSANDRA-18177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17693838#comment-17693838
 ] 

Yong Jiang commented on CASSANDRA-18177:
----------------------------------------

Hi, [~maxwellguo], thank you for your comments! I think the change in this 
feature still need to combine with your change in CASSANDRA-17698. I tested on 
my host, without the implementation from CASSANDRA-17698, the index table will 
need toJsonString method for PartitionerDefinedOrder, not 
AbstractCompositeType. It is [this 
line|https://github.com/apache/cassandra/pull/2004/files#diff-a7e8323c9332e6c0d12b0ef92709fa241342fc505a4bdf144b146e9f22cb9adaR750:~:text=.addClusteringColumn(%22partition_key%22%2C%20indexTableMokePkType)%3B]
 in your changes that will assign the AbstractCompositeType type.

So if I start my code based on trunk, there will be no straghtforward way for 
me to test it until the changes will be merged with yours. That's why I think 
it is better to have this feature implemented on top of CASSANDRA-17698.

 

> Support AbstractCompositeType with toJSONString method
> ------------------------------------------------------
>
>                 Key: CASSANDRA-18177
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-18177
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Local/SSTable
>            Reporter: maxwellguo
>            Assignee: Yong Jiang
>            Priority: Normal
>             Fix For: 4.x
>
>
> As we know AbstractCompositeType do not support toJSONString method , but 
> some times 
> we do need this.
> See the  discusstion of 
> [CASSANDRA-17698|https://issues.apache.org/jira/browse/CASSANDRA-17698].



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to