[
https://issues.apache.org/jira/browse/CASSANDRA-18328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17705139#comment-17705139
]
Andres de la Peña commented on CASSANDRA-18328:
-----------------------------------------------
Indeed those test failures on 3.0 and 3.11 when upgrading from 2.1 are caused
by this ticket. They are not a product defect but a test-only failure. 4.0, 4.1
and trunk should not be affected.
The problem is that {{toTimestamp}} et al. were introduced on 2.2, so they are
absent from 2.1. The test failures weren't caught by the pre-commit CI runs
because those runs were only for trunk. We should have tested all older
branches, even if they weren't affected by the patch, to validate the dtest
changes.
[This
patch|https://github.com/adelapena/cassandra-dtest/commit/df21bd4af1fa70d2b088abda58d8cd461ee4b742]
should fix the issue. Here are some CI runs:
|[3.0|https://app.circleci.com/pipelines/github/adelapena/cassandra/2736/workflows/eca7c081-9bac-4f4b-95ff-2b324fff59b5/jobs/32664]|
|[3.11|https://app.circleci.com/pipelines/github/adelapena/cassandra/2733/workflows/1ac2b932-c6ee-4939-8ee3-7fbd72b52809/jobs/32666]|
|[4.0|https://app.circleci.com/pipelines/github/adelapena/cassandra/2735/workflows/c5534d5a-1be3-467f-beca-c44e2b1a343c/jobs/32672]|
|[4.1|https://app.circleci.com/pipelines/github/adelapena/cassandra/2734/workflows/40e428d9-b96a-4c8f-bdef-7d5b090a45b2/jobs/32670]|
|[trunk|https://app.circleci.com/pipelines/github/adelapena/cassandra/2737/workflows/11d248c3-f4d2-4a40-9ad4-f0e9e9ab4e68/jobs/32671]|
> Remove deprecated CQL functions dateof and unixtimestampof
> ----------------------------------------------------------
>
> Key: CASSANDRA-18328
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18328
> Project: Cassandra
> Issue Type: Task
> Components: CQL/Syntax
> Reporter: Andres de la Peña
> Assignee: Andres de la Peña
> Priority: Normal
> Fix For: 5.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The CQL functions {{dateof}} and {{unixtimestampof}} were [deprecated on
> Cassandra
> 2.2.0|https://github.com/apache/cassandra/commit/c08aaabd95d4872593c29807de6ec1485cefa7fa],
> almost eight years ago. They were deprecated in favour of the then new
> {{totimestamp}} and {{tounixtimestamp}} functions.
> A note about their deprecation was added to
> [{{NEWS.txt}}|https://github.com/apache/cassandra/blob/trunk/NEWS.txt#L1421-L1423],
> and they were marked as deprecated on
> [{{CQL.textile}}|https://github.com/apache/cassandra/blob/trunk/doc/cql3/CQL.textile#time-conversion-functions].
> They are also listed as deprecated on [the new
> doc|https://github.com/apache/cassandra/blob/trunk/doc/modules/cassandra/pages/cql/functions.adoc#time-conversion-functions].
> We can finally remove those functions in 5.0, since they have been deprecated
> for so long.
> Discussion thread
> [here|https://lists.apache.org/thread/0gs824fpsngn5dr0yq2x1h8qsflj5sr0].
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
