[ 
https://issues.apache.org/jira/browse/CASSANDRA-18328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17707763#comment-17707763
 ] 

Berenguer Blasi commented on CASSANDRA-18328:
---------------------------------------------

Hi,

- 3.0 fails 
[upgrade_tests.upgrade_through_versions_test.TestProtoV3Upgrade_AllVersions_RandomPartitioner_EndsAt_3_11_X_HEAD|https://app.circleci.com/pipelines/github/adelapena/cassandra/2736/workflows/eca7c081-9bac-4f4b-95ff-2b324fff59b5/jobs/32664/tests].
 I checked jenkins and it is being 
[skipped|https://ci-cassandra.apache.org/job/Cassandra-3.0/340/testReport/dtest-upgrade.upgrade_tests.upgrade_through_versions_test/TestProtoV3Upgrade_AllVersions_RandomPartitioner_EndsAt_3_11_X_HEAD/]
 there, why the difference? Also if we check it's history in jenkins it wasn't 
getting skipped and was passing a few runs ago. So it seems there's sthg wrong 
here though it might not be related to this ticket?
- Many runs fail upgrade tests upon git errors. It might be worth retriggering 
them _but_ without the 'repeat' variant which go for 5h and fail to complete 
and provide any results

Otherwise the PR lgtm

> Remove deprecated CQL functions dateof and unixtimestampof
> ----------------------------------------------------------
>
>                 Key: CASSANDRA-18328
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-18328
>             Project: Cassandra
>          Issue Type: Task
>          Components: CQL/Syntax
>            Reporter: Andres de la Peña
>            Assignee: Andres de la Peña
>            Priority: Normal
>             Fix For: 5.0
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> The CQL functions {{dateof}} and {{unixtimestampof}} were [deprecated on 
> Cassandra 
> 2.2.0|https://github.com/apache/cassandra/commit/c08aaabd95d4872593c29807de6ec1485cefa7fa],
>  almost eight years ago. They were deprecated in favour of the then new 
> {{totimestamp}} and {{tounixtimestamp}} functions.
> A note about their deprecation was added to 
> [{{NEWS.txt}}|https://github.com/apache/cassandra/blob/trunk/NEWS.txt#L1421-L1423],
>  and they were marked as deprecated on 
> [{{CQL.textile}}|https://github.com/apache/cassandra/blob/trunk/doc/cql3/CQL.textile#time-conversion-functions].
>  They are also listed as deprecated on [the new 
> doc|https://github.com/apache/cassandra/blob/trunk/doc/modules/cassandra/pages/cql/functions.adoc#time-conversion-functions].
> We can finally remove those functions in 5.0, since they have been deprecated 
> for so long.
> Discussion thread 
> [here|https://lists.apache.org/thread/0gs824fpsngn5dr0yq2x1h8qsflj5sr0].



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to