[
https://issues.apache.org/jira/browse/CASSANDRA-18387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Abe Ratnofsky updated CASSANDRA-18387:
--------------------------------------
Authors: Abe Ratnofsky
Test and Documentation Plan: Run ./build-shaded-dtest-jar.sh to confirm
build is successful.
Status: Patch Available (was: Open)
Patch is simple:
{code:java}
diff --git a/build.xml b/build.xml
index 197f720472..4a4ea1fa8d 100644
--- a/build.xml
+++ b/build.xml
@@ -330,6 +330,9 @@
<include name="**/*.jar" />
<exclude name="**/ant-*.jar"/>
</fileset>
+ <fileset dir="${test.lib}/jars">
+ <include name="**/ant-junit-*.jar" />
+ </fileset>
</path>
<macrodef name="create-javadoc">
{code}
> Fix build script for shaded jvm-dtest JAR
> -----------------------------------------
>
> Key: CASSANDRA-18387
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18387
> Project: Cassandra
> Issue Type: Bug
> Components: Build, Test/dtest/java
> Reporter: Abe Ratnofsky
> Priority: Normal
>
> On trunk as of 6a5f84d0f44f5562776a12a678c7d68168d2c7e7,
> ./build-shaded-dtest-jar.sh fails with errors related to
> org.apache.tools.ant.taskdefs.optional.junit package visibility:
> {code}
> ...
> [javac] symbol: class JUnitTest
> [javac] location: class CassandraXMLJUnitResultFormatter
> [javac]
> /cassandra/test/unit/org/apache/cassandra/JStackJUnitTask.java:27: error:
> package org.apache.tools.ant.taskdefs.optional.junit does not exist
> [javac] import org.apache.tools.ant.taskdefs.optional.junit.JUnitTask;
> [javac] ^
> [javac]
> /cassandra/test/unit/org/apache/cassandra/JStackJUnitTask.java:30: error:
> cannot find symbol
> [javac] public class JStackJUnitTask extends JUnitTask
> [javac] ^
> [javac] symbol: class JUnitTask
> [javac] Note: Processing compiler hints annotations
> [javac] Note: Writing compiler command file at META-INF/hotspot_compiler
> [javac] Note: Done processing compiler hints annotations
> [javac] 22 errors
> BUILD FAILED
> /cassandra/build.xml:999: The following error occurred while executing this
> line:
> /cassandra/build.xml:1012: Compile failed; see the compiler error output for
> details.
> {code}
> Reproduced with Java 11, Maven 3.5.4, Ant 1.10.5.
> This is caused by the classpath exclusion of ${test.lib}/jars/**/ant-*.jar,
> which includes ant-junit, which is depended on by
> org.apache.cassandra.CassandraXMLJUnitResultFormatter.
> See:
> https://github.com/apache/cassandra/blob/6a5f84d0f44f5562776a12a678c7d68168d2c7e7/build.xml#L331
> To fix, update to include that library specifically:
> {code}
> <fileset dir="${test.lib}/jars">
> <include name="**/*.jar" />
> <exclude name="**/ant-*.jar"/>
> </fileset>
> + <fileset dir="${test.lib}/jars">
> + <include name="**/ant-junit-*.jar" />
> + </fileset>
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
