[ 
https://issues.apache.org/jira/browse/CASSANDRA-18262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17708862#comment-17708862
 ] 

Stefan Miklosovic commented on CASSANDRA-18262:
-----------------------------------------------

_I do not question that. I say it is confusing if you check against JDK11 stuff 
to realize you broke 8 after you put the effort to check yourself against 11._

I do not think we do any difference in our checkstyle rules between Java 8 and 
Java 11. The checkstyle itself is "version agnostic". It is more about what 
Java that checkstyle is triggered on.

_Isn’t it demotivating people to wait months for their work to be reviewed?_

My take is that it is better to have backlog full of checkstyle-valid patches 
waiting to be reviewed rather than smaller amount of patches potentially 
containing compilation issues in them.

> Switch checkstyle running only with JDK8 to be run with JDK11
> -------------------------------------------------------------
>
>                 Key: CASSANDRA-18262
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-18262
>             Project: Cassandra
>          Issue Type: Task
>          Components: Build
>            Reporter: Ekaterina Dimitrova
>            Assignee: Maxim Muzafarov
>            Priority: Normal
>             Fix For: 5.0
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Currently we run checkstyle, eclipse warnings (and probably anything else?) 
> only with JDK8.
> In preparation to remove JDK8 we need to switch those to run with JDK11.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to