[
https://issues.apache.org/jira/browse/CASSANDRA-18262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17708820#comment-17708820
]
Josh McKenzie commented on CASSANDRA-18262:
-------------------------------------------
{quote}it was decided(not by me) that we run it with the lowest version that we
release our builds with and we skip with the later ones.
{quote}
... when was this? I can see the argument for it (shouldn't be different
between any of the branches and _was_ somewhat slow), but Maxim's point
resonates with me:
{quote}Instead of tying the code-checking tool to a specific version, we should
make it work for every jdk we support. This has its advantages: you can run
checkstyle locally and check the sources without switching jdks
{quote}
Working on another JDK locally and not realizing it's not linting is a pretty
subtle and annoying thing IMO. I'm +1 to it running on all branches if it's
what, the 30 seconds per branch on formal builds to validate?
Maybe worth bringing to the dev list to get a quick consensus check and/or ping
[~mck] and [~brandon.williams] since they've both been maintaining build stuff
recently.
> Switch checkstyle running only with JDK8 to be run with JDK11
> -------------------------------------------------------------
>
> Key: CASSANDRA-18262
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18262
> Project: Cassandra
> Issue Type: Task
> Components: Build
> Reporter: Ekaterina Dimitrova
> Assignee: Maxim Muzafarov
> Priority: Normal
> Fix For: 5.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently we run checkstyle, eclipse warnings (and probably anything else?)
> only with JDK8.
> In preparation to remove JDK8 we need to switch those to run with JDK11.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
