[
https://issues.apache.org/jira/browse/CASSANDRA-18267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17711165#comment-17711165
]
Ekaterina Dimitrova edited comment on CASSANDRA-18267 at 4/12/23 1:47 AM:
--------------------------------------------------------------------------
test/anttasks are compiled with _build-test target.
keepBrief could be simplified not to use a java custom ant task at all. Fix
[here|https://github.com/ekaterinadimitrova2/cassandra/commit/10fe617ed01ef4d3d2938571d5c696715ab2ed90]
This is trunk but 4.1 will have the same patch.
Tested locally:
1) Created tiny testlist.txt (just a few tests) with the following content:
{code:java}
org/apache/cassandra/auth/CassandraAuthorizerTruncatingTest.java
org/apache/cassandra/concurrent/SEPExecutorTest.java
org/apache/cassandra/cql3/CQL3TypeLiteralTest.java
org/apache/cassandra/cql3/QueryEventsTest.java
{code}
2) ant testclasslist -Dno-checkstyle=true - prints brief console output
3) ant testclasslist -Dno-checkstyle=true -Dcassandra.keepBriefBrief=true -
prints brief console output
4) ant testclasslist -Dno-checkstyle=true -Dcassandra.keepBriefBrief=false -
prints noisy console output
[~adelapena] do you mind to review, please?
Once the patch is confirmed I will run it through CI with both 4.1 and trunk.
was (Author: e.dimitrova):
test/anttasks are compiled with _build-test target.
keepBrief could be simplified not to use a java custom ant task at all. Fix
[here|https://github.com/ekaterinadimitrova2/cassandra/commit/10fe617ed01ef4d3d2938571d5c696715ab2ed90]
This is trunk but 4.1 will have the same patch.
Tested locally:
1) Created tiny testlist.txt with just a few tests with the following content:
{code:java}
org/apache/cassandra/auth/CassandraAuthorizerTruncatingTest.java
org/apache/cassandra/concurrent/SEPExecutorTest.java
org/apache/cassandra/cql3/CQL3TypeLiteralTest.java
org/apache/cassandra/cql3/QueryEventsTest.java
{code}
2) ant testclasslist -Dno-checkstyle=true - prints brief console output
3) ant testclasslist -Dno-checkstyle=true -Dcassandra.keepBriefBrief=true -
prints brief console output
4) ant testclasslist -Dno-checkstyle=true -Dcassandra.keepBriefBrief=false -
prints noisy console output
[~adelapena] do you mind to review, please?
Once the patch is confirmed I will run it through CI with both 4.1 and trunk.
> keepbrief is not called
> -----------------------
>
> Key: CASSANDRA-18267
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18267
> Project: Cassandra
> Issue Type: Bug
> Components: Build
> Reporter: Michael Semb Wever
> Assignee: Ekaterina Dimitrova
> Priority: Normal
> Fix For: 4.1.x, 5.x
>
>
> Discovered in CASSANDRA-18179
> The keepbrief macro is never called in build.xml
> And attempts to use it result in
> {noformat}
> Buildfile: /Users/mick/src/apache/cassandra/build.xml
> [javac] Compiling 5 source files to
> /Users/mick/src/apache/cassandra/build/test/classes
> [javac]
> /Users/mick/src/apache/cassandra/test/anttasks/org/apache/cassandra/anttasks/EchoEclipseProjectLibs.java:21:
> error: package org.apache.cassandra.io.util does not exist
> [javac] import org.apache.cassandra.io.util.File;
> [javac] ^
> [javac]
> /Users/mick/src/apache/cassandra/test/anttasks/org/apache/cassandra/anttasks/EchoEclipseProjectLibs.java:23:
> error: package org.apache.commons.io does not exist
> [javac] import org.apache.commons.io.FilenameUtils;
> [javac] ^
> [javac]
> /Users/mick/src/apache/cassandra/test/anttasks/org/apache/cassandra/anttasks/TestNameCheckTask.java:26:
> error: package org.junit does not exist
> [javac] import org.junit.Test;
> [javac] ^
> [javac]
> /Users/mick/src/apache/cassandra/test/anttasks/org/apache/cassandra/anttasks/TestNameCheckTask.java:30:
> error: package org.reflections does not exist
> [javac] import org.reflections.Reflections;
> [javac] ^
> [javac]
> /Users/mick/src/apache/cassandra/test/anttasks/org/apache/cassandra/anttasks/TestNameCheckTask.java:31:
> error: package org.reflections.scanners does not exist
> [javac] import org.reflections.scanners.Scanners;
> [javac] ^
> [javac]
> /Users/mick/src/apache/cassandra/test/anttasks/org/apache/cassandra/anttasks/TestNameCheckTask.java:32:
> error: package org.reflections.util does not exist
> [javac] import org.reflections.util.ConfigurationBuilder;
> [javac] ^
> [javac]
> /Users/mick/src/apache/cassandra/test/anttasks/org/apache/cassandra/anttasks/TestNameCheckTask.java:38:
> error: cannot find symbol
> [javac] private static final Reflections reflections = new
> Reflections(new ConfigurationBuilder()
> [javac] ^
> [javac] symbol: class Reflections
> [javac] location: class TestNameCheckTask
> [javac]
> /Users/mick/src/apache/cassandra/test/anttasks/org/apache/cassandra/anttasks/EchoEclipseProjectLibs.java:38:
> error: cannot find symbol
> [javac] echo.setFile(new File(".classpath").toJavaIOFile());
> [javac] ^
> [javac] symbol: class File
> [javac] location: class EchoEclipseProjectLibs
> [javac]
> /Users/mick/src/apache/cassandra/test/anttasks/org/apache/cassandra/anttasks/EchoEclipseProjectLibs.java:52:
> error: cannot find symbol
> [javac] String srcJar = FilenameUtils.getBaseName(jars[i]) +
> "-sources.jar";
> [javac] ^
> [javac] symbol: variable FilenameUtils
> [javac] location: class EchoEclipseProjectLibs
> [javac]
> /Users/mick/src/apache/cassandra/test/anttasks/org/apache/cassandra/anttasks/EchoEclipseProjectLibs.java:53:
> error: cannot find symbol
> [javac] String srcDir =
> FilenameUtils.concat(project.getProperty("build.test.dir"), "sources");
> [javac] ^
> [javac] symbol: variable FilenameUtils
> [javac] location: class EchoEclipseProjectLibs
> [javac]
> /Users/mick/src/apache/cassandra/test/anttasks/org/apache/cassandra/anttasks/EchoEclipseProjectLibs.java:54:
> error: cannot find symbol
> [javac] File srcFile = new File(FilenameUtils.concat(srcDir,
> srcJar));
> [javac] ^
> [javac] symbol: class File
> [javac] location: class EchoEclipseProjectLibs
> [javac]
> /Users/mick/src/apache/cassandra/test/anttasks/org/apache/cassandra/anttasks/EchoEclipseProjectLibs.java:54:
> error: cannot find symbol
> [javac] File srcFile = new File(FilenameUtils.concat(srcDir,
> srcJar));
> [javac] ^
> [javac] symbol: class File
> [javac] location: class EchoEclipseProjectLibs
> [javac]
> /Users/mick/src/apache/cassandra/test/anttasks/org/apache/cassandra/anttasks/EchoEclipseProjectLibs.java:54:
> error: cannot find symbol
> [javac] File srcFile = new File(FilenameUtils.concat(srcDir,
> srcJar));
> [javac] ^
> [javac] symbol: variable FilenameUtils
> [javac] location: class EchoEclipseProjectLibs
> [javac]
> /Users/mick/src/apache/cassandra/test/anttasks/org/apache/cassandra/anttasks/TestNameCheckTask.java:38:
> error: cannot find symbol
> [javac] private static final Reflections reflections = new
> Reflections(new ConfigurationBuilder()
> [javac] ^
> [javac] symbol: class Reflections
> [javac] location: class TestNameCheckTask
> [javac]
> /Users/mick/src/apache/cassandra/test/anttasks/org/apache/cassandra/anttasks/TestNameCheckTask.java:40:
> error: cannot find symbol
> [javac]
> .setScanners(Scanners.MethodsAnnotated, Scanners.SubTypes)
> [javac]
> ^
> [javac] symbol: variable Scanners
> [javac] location: class TestNameCheckTask
> [javac]
> /Users/mick/src/apache/cassandra/test/anttasks/org/apache/cassandra/anttasks/TestNameCheckTask.java:40:
> error: cannot find symbol
> [javac]
> .setScanners(Scanners.MethodsAnnotated, Scanners.SubTypes)
> [javac]
> ^
> [javac] symbol: variable Scanners
> [javac] location: class TestNameCheckTask
> [javac]
> /Users/mick/src/apache/cassandra/test/anttasks/org/apache/cassandra/anttasks/TestNameCheckTask.java:38:
> error: cannot find symbol
> [javac] private static final Reflections reflections = new
> Reflections(new ConfigurationBuilder()
> [javac]
> ^
> [javac] symbol: class ConfigurationBuilder
> [javac] location: class TestNameCheckTask
> [javac]
> /Users/mick/src/apache/cassandra/test/anttasks/org/apache/cassandra/anttasks/TestNameCheckTask.java:51:
> error: cannot find symbol
> [javac] Set<Method> methodsAnnotatedWith =
> reflections.getMethodsAnnotatedWith(Test.class);
> [javac]
> ^
> [javac] symbol: class Test
> [javac] location: class TestNameCheckTask
> [javac] Note:
> /Users/mick/src/apache/cassandra/test/anttasks/org/apache/cassandra/anttasks/TestNameCheckTask.java
> uses unchecked or unsafe operations.
> [javac] Note: Recompile with -Xlint:unchecked for details.
> [javac] 18 errors
> BUILD FAILED
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
