[
https://issues.apache.org/jira/browse/CASSANDRA-18267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17711397#comment-17711397
]
Andres de la Peña edited comment on CASSANDRA-18267 at 4/12/23 1:47 PM:
------------------------------------------------------------------------
I have tested the following cases:
||Ant command||No
args||-Dcassandra.keepBriefBrief=true||-Dcassandra.keepBriefBrief=false||
|ant testclasslist|brief output|brief output|long output|
|ant testsome -Dtest.name=...|long output|brief output|long output|
|ant test|brief output|brief output|long output|
I think that's the expected behaviour.
It always works as expected if the {{cassandra.keepBriefBrief}} property is
specified. However, if the property is not specified there can be slightly
surprising cases:
* A {{testlist.txt}} with a single class will produce a brief output, clashing
a bit with the comment on {{{}build.xml{}}}.
* A call to {{ant testsome -Dtest.name="*est"}} will produce a long output,
whereas {{ant testsome -Dtest.name="*Test"}} will produce a brief output.
I think it would be ideal if the default behaviour depended on the number of
tests, rather than on the use of the "*Test" expression. But that's an
improvement that can be done on a separate ticket. IMO the current patch
restores the pre-CASSANDRA-17234 behaviour, +1.
was (Author: adelapena):
I have tested the following cases:
||Ant command||No
args||-Dcassandra.keepBriefBrief=true||-Dcassandra.keepBriefBrief=false||
|ant testclasslist|brief output|brief output|long output|
|ant testsome -Dtest.name=...|long output|brief output|long output|
|ant test|brief output|brief output|long output|
I think that's the expected behaviour.
It always works as expected if the {{cassandra.keepBriefBrief}} property is
specified. However, if the property is not specified there can be slightly
surprising cases:
* A {{testlist.txt}} with a single class will produce a brief output, clashing
a bit with the comment on {{{}build.xml{}}}.
* A call to {{ant testsome -Dtest.name="*est"}} will produce a brief output,
whereas {{ant testsome -Dtest.name="*Test"}} will produce a long output.
I think it would be ideal if the default behaviour depended on the number of
tests, rather than on the use of the "*Test" expression. But that's an
improvement that can be done on a separate ticket. IMO the current patch
restores the pre-CASSANDRA-17234 behaviour, +1.
> keepbrief is not called
> -----------------------
>
> Key: CASSANDRA-18267
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18267
> Project: Cassandra
> Issue Type: Bug
> Components: Build
> Reporter: Michael Semb Wever
> Assignee: Ekaterina Dimitrova
> Priority: Normal
> Fix For: 4.1.x, 5.x
>
>
> Discovered in CASSANDRA-18179
> The keepbrief macro is never called in build.xml
> And attempts to use it result in
> {noformat}
> Buildfile: /Users/mick/src/apache/cassandra/build.xml
> [javac] Compiling 5 source files to
> /Users/mick/src/apache/cassandra/build/test/classes
> [javac]
> /Users/mick/src/apache/cassandra/test/anttasks/org/apache/cassandra/anttasks/EchoEclipseProjectLibs.java:21:
> error: package org.apache.cassandra.io.util does not exist
> [javac] import org.apache.cassandra.io.util.File;
> [javac] ^
> [javac]
> /Users/mick/src/apache/cassandra/test/anttasks/org/apache/cassandra/anttasks/EchoEclipseProjectLibs.java:23:
> error: package org.apache.commons.io does not exist
> [javac] import org.apache.commons.io.FilenameUtils;
> [javac] ^
> [javac]
> /Users/mick/src/apache/cassandra/test/anttasks/org/apache/cassandra/anttasks/TestNameCheckTask.java:26:
> error: package org.junit does not exist
> [javac] import org.junit.Test;
> [javac] ^
> [javac]
> /Users/mick/src/apache/cassandra/test/anttasks/org/apache/cassandra/anttasks/TestNameCheckTask.java:30:
> error: package org.reflections does not exist
> [javac] import org.reflections.Reflections;
> [javac] ^
> [javac]
> /Users/mick/src/apache/cassandra/test/anttasks/org/apache/cassandra/anttasks/TestNameCheckTask.java:31:
> error: package org.reflections.scanners does not exist
> [javac] import org.reflections.scanners.Scanners;
> [javac] ^
> [javac]
> /Users/mick/src/apache/cassandra/test/anttasks/org/apache/cassandra/anttasks/TestNameCheckTask.java:32:
> error: package org.reflections.util does not exist
> [javac] import org.reflections.util.ConfigurationBuilder;
> [javac] ^
> [javac]
> /Users/mick/src/apache/cassandra/test/anttasks/org/apache/cassandra/anttasks/TestNameCheckTask.java:38:
> error: cannot find symbol
> [javac] private static final Reflections reflections = new
> Reflections(new ConfigurationBuilder()
> [javac] ^
> [javac] symbol: class Reflections
> [javac] location: class TestNameCheckTask
> [javac]
> /Users/mick/src/apache/cassandra/test/anttasks/org/apache/cassandra/anttasks/EchoEclipseProjectLibs.java:38:
> error: cannot find symbol
> [javac] echo.setFile(new File(".classpath").toJavaIOFile());
> [javac] ^
> [javac] symbol: class File
> [javac] location: class EchoEclipseProjectLibs
> [javac]
> /Users/mick/src/apache/cassandra/test/anttasks/org/apache/cassandra/anttasks/EchoEclipseProjectLibs.java:52:
> error: cannot find symbol
> [javac] String srcJar = FilenameUtils.getBaseName(jars[i]) +
> "-sources.jar";
> [javac] ^
> [javac] symbol: variable FilenameUtils
> [javac] location: class EchoEclipseProjectLibs
> [javac]
> /Users/mick/src/apache/cassandra/test/anttasks/org/apache/cassandra/anttasks/EchoEclipseProjectLibs.java:53:
> error: cannot find symbol
> [javac] String srcDir =
> FilenameUtils.concat(project.getProperty("build.test.dir"), "sources");
> [javac] ^
> [javac] symbol: variable FilenameUtils
> [javac] location: class EchoEclipseProjectLibs
> [javac]
> /Users/mick/src/apache/cassandra/test/anttasks/org/apache/cassandra/anttasks/EchoEclipseProjectLibs.java:54:
> error: cannot find symbol
> [javac] File srcFile = new File(FilenameUtils.concat(srcDir,
> srcJar));
> [javac] ^
> [javac] symbol: class File
> [javac] location: class EchoEclipseProjectLibs
> [javac]
> /Users/mick/src/apache/cassandra/test/anttasks/org/apache/cassandra/anttasks/EchoEclipseProjectLibs.java:54:
> error: cannot find symbol
> [javac] File srcFile = new File(FilenameUtils.concat(srcDir,
> srcJar));
> [javac] ^
> [javac] symbol: class File
> [javac] location: class EchoEclipseProjectLibs
> [javac]
> /Users/mick/src/apache/cassandra/test/anttasks/org/apache/cassandra/anttasks/EchoEclipseProjectLibs.java:54:
> error: cannot find symbol
> [javac] File srcFile = new File(FilenameUtils.concat(srcDir,
> srcJar));
> [javac] ^
> [javac] symbol: variable FilenameUtils
> [javac] location: class EchoEclipseProjectLibs
> [javac]
> /Users/mick/src/apache/cassandra/test/anttasks/org/apache/cassandra/anttasks/TestNameCheckTask.java:38:
> error: cannot find symbol
> [javac] private static final Reflections reflections = new
> Reflections(new ConfigurationBuilder()
> [javac] ^
> [javac] symbol: class Reflections
> [javac] location: class TestNameCheckTask
> [javac]
> /Users/mick/src/apache/cassandra/test/anttasks/org/apache/cassandra/anttasks/TestNameCheckTask.java:40:
> error: cannot find symbol
> [javac]
> .setScanners(Scanners.MethodsAnnotated, Scanners.SubTypes)
> [javac]
> ^
> [javac] symbol: variable Scanners
> [javac] location: class TestNameCheckTask
> [javac]
> /Users/mick/src/apache/cassandra/test/anttasks/org/apache/cassandra/anttasks/TestNameCheckTask.java:40:
> error: cannot find symbol
> [javac]
> .setScanners(Scanners.MethodsAnnotated, Scanners.SubTypes)
> [javac]
> ^
> [javac] symbol: variable Scanners
> [javac] location: class TestNameCheckTask
> [javac]
> /Users/mick/src/apache/cassandra/test/anttasks/org/apache/cassandra/anttasks/TestNameCheckTask.java:38:
> error: cannot find symbol
> [javac] private static final Reflections reflections = new
> Reflections(new ConfigurationBuilder()
> [javac]
> ^
> [javac] symbol: class ConfigurationBuilder
> [javac] location: class TestNameCheckTask
> [javac]
> /Users/mick/src/apache/cassandra/test/anttasks/org/apache/cassandra/anttasks/TestNameCheckTask.java:51:
> error: cannot find symbol
> [javac] Set<Method> methodsAnnotatedWith =
> reflections.getMethodsAnnotatedWith(Test.class);
> [javac]
> ^
> [javac] symbol: class Test
> [javac] location: class TestNameCheckTask
> [javac] Note:
> /Users/mick/src/apache/cassandra/test/anttasks/org/apache/cassandra/anttasks/TestNameCheckTask.java
> uses unchecked or unsafe operations.
> [javac] Note: Recompile with -Xlint:unchecked for details.
> [javac] 18 errors
> BUILD FAILED
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
