[
https://issues.apache.org/jira/browse/CASSANDRA-17869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17712032#comment-17712032
]
Ekaterina Dimitrova edited comment on CASSANDRA-17869 at 4/13/23 7:16 PM:
--------------------------------------------------------------------------
Test runs look way better now, I left some questions on your commits.
Most of them are about how we select what upgrade path to run.
Main ones that bother me:
* now we run many more tests for Python upgrade tests and I do not understand
certain changes. Maybe it's just me. I left questions on the commits
* In-jvm upgrade tests run the same amount of tests we were running with JDK8
and they all pass? I would have expected there were certain paths from 3, 3.11
that we skip now? Where do we check the JDK version for them, similar to what
you did for python dtests here:
[https://github.com/apache/cassandra-dtest/commit/824c90c4d8b606d3beffc57f99c666d41828bca8#diff-16fb32b744845ae88f5f9638516d36b89d7ff14b2215779c3dc8959e567c8ab2R262]
was (Author: e.dimitrova):
Test runs look way better now, I left some questions on your commits.
Most of them are about how we select what upgrade path to run.
Main ones that bother me:
* now we run many more tests for Python upgrade tests and I do not understand
certain changes. Maybe it's just me. I left questions on the commits
* In-jvm upgrade tests run the same amount of tests we were running with JDK8
and they all pass? I would have expected there were certain paths from 3, 3.11
that we skipped? Where do we check the JDK version for them, similar to what
you did for python dtests here:
[https://github.com/apache/cassandra-dtest/commit/824c90c4d8b606d3beffc57f99c666d41828bca8#diff-16fb32b744845ae88f5f9638516d36b89d7ff14b2215779c3dc8959e567c8ab2R262]
> Add JDK17 option to cassandra-builds (build-scripts and jenkins dsl) and on
> jenkins agents
> ------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-17869
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17869
> Project: Cassandra
> Issue Type: Task
> Components: Build
> Reporter: Michael Semb Wever
> Assignee: Michael Semb Wever
> Priority: Normal
> Fix For: 5.x
>
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> Add JDK17 option to cassandra-builds build-scripts, they only currently
> support options {{8}} and {{11}}.
> Add JDK17 to the matrix axes in the jenkins dsl.
> Ensure JDK17 is installed on all the jenkins agents.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
