[
https://issues.apache.org/jira/browse/CASSANDRA-18396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17713607#comment-17713607
]
Andres de la Peña commented on CASSANDRA-18396:
-----------------------------------------------
Here is the PR updating {{@ported_to_in_jvm}} to also skip tests with vnodes if
they have been ported and the tested branch is greater than or equals to 4.1:
[https://github.com/apache/cassandra-dtest/pull/218]
Here are the CI results for the patch, compared to the unpatched branches:
||Branch||Not patched||Patched||
|3.0|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/2853/workflows/0ca41e5b-3e85-4ad4-8547-5a9ea53b9cd4]|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/2860/workflows/e16506bc-a3e7-4c0a-8286-c06cde073d7b]|
|3.11|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/2854/workflows/89215583-16fb-416b-85bd-2b4933cf0fb8]|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/2862/workflows/04437fef-aa6a-49b3-8aa0-9b494aa9c298]|
|4.0|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/2855/workflows/46c3897a-c4a2-42a7-96a2-8a32017e4803]
[j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/2855/workflows/d40c4e30-649b-4190-bd43-0d0780bb17bb]|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/2859/workflows/8d71cd82-c29b-40f9-b6ec-c9c00b1c7d2e]
[j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/2859/workflows/e452139d-9f9e-4f8f-8db6-1b49c62a75e2]|
|4.1|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/2856/workflows/6ad2b6e9-0764-4500-b5a7-55925edbe048]
[j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/2856/workflows/ec949f73-cd1b-450c-a910-17d90188c75f]|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/2861/workflows/2c071cf4-b1ee-4f19-9aa6-2887f7caac29]
[j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/2861/workflows/74e02978-d8c9-4bc7-8fc2-0d2c74726428]|
|trunk|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/2857/workflows/9317d1bf-e533-42fe-b456-0fcf17efa0a8]
[j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/2857/workflows/cb55fee4-8987-4279-9af3-9cee0f5c5da8]|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/2858/workflows/aeb788d7-8669-40e2-882f-a67642f04647]
[j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/2858/workflows/03c1a210-66b9-47fd-a9d3-55abac4269a6]|
CircleCI UI make it difficult to read how many tests have been run, but the
artifacts tab allows to see if the proper tests have been skipped.
The skipped tests on trunk are:
*
{{bootstrap_test.py::BootstrapTester::test_node_cannot_join_as_hibernating_node_without_replace_address}}
* {{consistency_test.py::TestConsistency::test_13911}}
* {{consistency_test.py::TestConsistency::test_13911_rows_srp}}
* {{consistency_test.py::TestConsistency::test_13911_partitions_srp}}
* {{consistency_test.py::TestConsistency::test_13880}}
* {{consistency_test.py::TestConsistency::test_13747}}
* {{consistency_test.py::TestConsistency::test_13595}}
* {{consistency_test.py::TestConsistency::test_12872}}
* {{consistency_test.py::TestConsistency::test_short_read}}
* {{consistency_test.py::TestConsistency::test_short_read_delete}}
* {{consistency_test.py::TestConsistency::test_short_read_quorum_delete}}
* {{consistency_test.py::TestConsistency::test_readrepair}}
* {{hintedhandoff_test.py::TestHintedHandoffConfig::test_nodetool}}
* {{putget_test.py::TestPutGet::test_putget}}
* {{putget_test.py::TestPutGet::test_putget_snappy}}
* {{putget_test.py::TestPutGet::test_putget_deflate}}
* {{putget_test.py::TestPutGet::test_non_local_read}}
* {{putget_test.py::TestPutGet::test_rangeputget}}
* {{putget_test.py::TestPutGet::test_wide_row}}
* {{putget_test.py::TestPutGet::test_wide_slice}}
* {{read_repair_test.py::TestReadRepair::test_alter_rf_and_run_read_repair}}
*
{{read_repair_test.py::TestReadRepair::test_range_slice_query_with_tombstones}}
*
{{read_repair_test.py::TestReadRepair::test_gcable_tombstone_resurrection_on_range_slice_query}}
* {{read_repair_test.py::TestReadRepairGuarantees::test_monotonic_reads}}
* {{read_repair_test.py::TestReadRepairGuarantees::test_atomic_writes}}
Those were being skipped only when vnodes weren't involved. Now they are always
skipped independently of the usage of vnodes.
> Dtests marked with @ported_to_in_jvm can be skipped since 4.1
> -------------------------------------------------------------
>
> Key: CASSANDRA-18396
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18396
> Project: Cassandra
> Issue Type: Improvement
> Components: Test/dtest/python
> Reporter: Andres de la Peña
> Assignee: Andres de la Peña
> Priority: Normal
>
> During the CASSANDRA-15536 epic we ported multiple Python dtests to in-JVM
> dtests.
> The ported Python dtests are still present but marked with a new
> {{@ported_to_in_jvm}} annotation. JVM dtests didn't support vnodes at that
> time, so when a Python dtest is marked with that annotation it's only run for
> vnodes config, whereas it's skipped if vnodes are off.
> However, we have had support for vnodes on JVM dtests since 4.1. Thus, I
> think we should modify the {{@ported_to_in_jvm}} annotation to also skip
> configs with vnodes if all the nodes are in 4.1 or later.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
