[
https://issues.apache.org/jira/browse/CASSANDRA-18396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17713612#comment-17713612
]
Andres de la Peña commented on CASSANDRA-18396:
-----------------------------------------------
Note that I have also fixed [a
mistake|https://github.com/apache/cassandra-dtest/blob/c49bcf307686886fb34eea646eb3e7ff5855eb03/conftest.py#L494]
that we accidentally introduced on CASSANDRA-18391, where
{{fixture_ported_to_in_jvm}} was calling to {{_skip_msg}} instead of
{{_skip_ported_msg}}. That doesn't have any consequences in practice because we
don't have any upgrade dtests annotated with {{ported_to_in_jvm}}.
> Dtests marked with @ported_to_in_jvm can be skipped since 4.1
> -------------------------------------------------------------
>
> Key: CASSANDRA-18396
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18396
> Project: Cassandra
> Issue Type: Improvement
> Components: Test/dtest/python
> Reporter: Andres de la Peña
> Assignee: Andres de la Peña
> Priority: Normal
>
> During the CASSANDRA-15536 epic we ported multiple Python dtests to in-JVM
> dtests.
> The ported Python dtests are still present but marked with a new
> {{@ported_to_in_jvm}} annotation. JVM dtests didn't support vnodes at that
> time, so when a Python dtest is marked with that annotation it's only run for
> vnodes config, whereas it's skipped if vnodes are off.
> However, we have had support for vnodes on JVM dtests since 4.1. Thus, I
> think we should modify the {{@ported_to_in_jvm}} annotation to also skip
> configs with vnodes if all the nodes are in 4.1 or later.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
