[
https://issues.apache.org/jira/browse/CASSANDRA-18507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17721821#comment-17721821
]
Ekaterina Dimitrova edited comment on CASSANDRA-18507 at 5/11/23 3:06 PM:
--------------------------------------------------------------------------
Hey everyone,
I also have a Mac available so decided to test on my end too. I can confirm
that I pulled [https://github.com/krummas/cassandra/tree/CASSANDRA-18507-4.1]
and [https://github.com/krummas/cassandra/tree/CASSANDRA-18507-4.0]. Then:
{code:java}
ant realclean
ant jar
{code}
ant test -Dtest.name=PartialCompactionsTest -Duse.jdk11=true
Everything finished successfully for me.
To be on the safe side I also tested with JDK 8. I ran this with both branches.
I tried on Mac Book pro from 2018, MAC OS 12.06
{code:java}
openjdk version "11.0.2" 2019-01-15
OpenJDK Runtime Environment 18.9 (build 11.0.2+9)
OpenJDK 64-Bit Server VM 18.9 (build 11.0.2+9, mixed mode)
{code}
and
{code:java}
java version "1.8.0_231"
Java(TM) SE Runtime Environment (build 1.8.0_231-b11)
Java HotSpot(TM) 64-Bit Server VM (build 25.231-b11, mixed mode)
{code}
[~marcuse], can you push to run also the JDK 11 workflow In CI, please? I
noticed you started only JDK8 workflow.
{quote} I do think we will want this test for trunk just to make sure this
regression doesn't come back.
{quote}
That sounds like a great idea to me.
was (Author: e.dimitrova):
Hey everyone,
I also have a Mac available so decided to test on my end too. I can confirm
that I pulled [https://github.com/krummas/cassandra/tree/CASSANDRA-18507-4.1]
and [https://github.com/krummas/cassandra/tree/CASSANDRA-18507-4.0]. Then:
{code:java}
ant realclean
ant jar
{code}
ant test -Dtest.name=PartialCompactionsTest -Duse.jdk11=true
Everything finished successfully for me.
To be on the safe side I also tested with JDK 8. I ran this with both branches.
I tried on Mac Book pro from 2018, MAC OS 12.06
{code:java}
openjdk version "11.0.2" 2019-01-15
OpenJDK Runtime Environment 18.9 (build 11.0.2+9)
OpenJDK 64-Bit Server VM 18.9 (build 11.0.2+9, mixed mode)
{code}
and
{code:java}
java version "1.8.0_231"
Java(TM) SE Runtime Environment (build 1.8.0_231-b11)
Java HotSpot(TM) 64-Bit Server VM (build 25.231-b11, mixed mode)
{code}
[~marcuse], can you push to run also the JDK 11 workflow In CI, please? I
noticed you started only JDK8 workflow.
{quote} I do think we will want this test for trunk just to make sure this
regression doesn't come back.
{quote}
That sounds like a great idea to me.
> Partial compaction can resurrect deleted data
> ---------------------------------------------
>
> Key: CASSANDRA-18507
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18507
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Compaction
> Reporter: Tobias Lindaaker
> Assignee: Tobias Lindaaker
> Priority: Normal
>
> If there isn't enough disk space available to compact all existing sstables,
> Cassandra will attempt to perform a partial compaction by removing sstables
> from the set of candidate sstables to be compacted, starting with the largest
> one. It is possible that the sstable removed from the set of sstables to
> compact contains data for which there are tombstones in another (more recent)
> sstable. Since the overlaps between sstables is computed when the
> {{CompactionController}} is created, and the {{CompactionController}} is
> created before the removal of any sstables from the set of sstables to be
> compacted this computed overlap will be outdated when checking which sstables
> are covered by certain tombstones. This leads to the faulty conclusion that
> the tombstones can be pruned during the compaction, causing the data to be
> resurrected.
> The issue is present in Cassandra 4.0 and 4.1. Cassandra 3.11 creates the
> {{CompactionController}} after the set of sstables to compact has been
> reduced, and is thus not affected. {{trunk}} does not appear to support
> partial compactions at all, but instead refuses to compact when the disk is
> full.
> This regression appears to have been introduced by CASSANDRA-13068.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
