[ 
https://issues.apache.org/jira/browse/CASSANDRA-18305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17736065#comment-17736065
 ] 

Stefan Miklosovic commented on CASSANDRA-18305:
-----------------------------------------------

[~bschoeni]

why do you think this is important to see?

{code}
minute rate                      0.00/second                                    
                                                                                
                                                                    
5 minute rate                    0.01/second                                    
                                                                                
                                                                    
15 minute rate                   0.12/second                                    
                                                                                
                                                                    
mean rate                        0.01/second  
{code}

or as you put it in the description:

{code}
pending tasks: 0

compactions completed: 20

    1 minute rate:    0/second

   5 minute rate:    2.3/second

  15 minute rate:   4.6/second
{code}

What I mean by that is that I do not see any reason to have these metrics 
there, what practical information you get from this? If it was a number of how 
many compactions there were in 15 minutes I might get that, but what is useful 
in knowing that there was 0.12 compactions per second over 15 minutes?


> Enhance nodetool compactionstats with existing MBean metrics
> ------------------------------------------------------------
>
>                 Key: CASSANDRA-18305
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-18305
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Tool/nodetool
>            Reporter: Brad Schoening
>            Assignee: Manish Ghildiyal
>            Priority: Normal
>             Fix For: 4.0.x, 4.1.x, 5.x
>
>          Time Spent: 3h 10m
>  Remaining Estimate: 0h
>
> Nodetool compactionstats reports only on active compactions, if nothing is 
> active, you see only:
> {quote}$nodetool compactionstats
> pending tasks: 0
> {quote}
> but in the MBean Compaction/TotalCompactionsCompleted there are recent 
> statistic in events/second for:
>  * Count
>  * FifteenMinueRate
>  * FiveMinueRate
>  * MeanRate
>  * OneMinuteRate
> 1) It would be useful to see in addition:
> {quote}pending tasks: 0
> compactions completed: 20
>     1 minute rate:    0/second
>    5 minute rate:    2.3/second
>   15 minute rate:   4.6/second
> {quote}
> 2) Since compaction_throughput_mb_per_sec is a throttling parameter in 
> cassandra.yaml (default 64 MBps), it would be nice to show the actual 
> compaction throughput and be able to observe if you're close to the limit.  
> I.e., 
> {quote}compaction throughput 13.2 MBps / 16 MBps (82.5%)
> {quote}
> 3) for completness, compactionstats should list the number of concurrent 
> compactors configured, perhaps simply add to existing 'pending tasks' line:
> {quote}4 concurrent compactors, 0 pending tasks
> {quote}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to