[ 
https://issues.apache.org/jira/browse/CASSANDRA-18490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740317#comment-17740317
 ] 

Caleb Rackliffe commented on CASSANDRA-18490:
---------------------------------------------

Reviewed the PR and left my comments, including some suggestions around the new 
test failures. Overall, LGTM.

The only thing I guess I'm not 100% clear on is whether we're definitely not 
going to want optional checksumming of anything on startup. I'm not going to 
push super hard for it, and I understand the reasons for leaving it out (at 
least for now). We've got what might be the same exact problem to solve in 
CASSANDRA-18535, etc.

CC [~mike_tr_adamson]

> Add checksum validation to all index components on startup, streaming, and 
> SSTable import
> -----------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-18490
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-18490
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Feature/2i Index
>            Reporter: Mike Adamson
>            Assignee: Piotr Kolaczkowski
>            Priority: Normal
>             Fix For: 5.x
>
>
> The SAI code currently does not checksum validate per-column index data files 
> at any point. It does checksum validate per-sstable components after a full 
> rebuild and it checksum validates the per-column metadata on opening.
> We should checksum validate all index components on startup, full rebuild and 
> streaming.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to