[
https://issues.apache.org/jira/browse/CASSANDRA-18428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Maxim Muzafarov updated CASSANDRA-18428:
----------------------------------------
Fix Version/s: 5.x
> Implement/override equals and hashCode methods in the ServerEncryptionOptions
> class
> -----------------------------------------------------------------------------------
>
> Key: CASSANDRA-18428
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18428
> Project: Cassandra
> Issue Type: Improvement
> Components: Local/Config
> Reporter: Maulin Vasavada
> Assignee: Maulin Vasavada
> Priority: Normal
> Labels: lhf
> Fix For: 5.x
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> We have {{equals and hashCode}} methods in
> [EncryptionOptions|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/config/EncryptionOptions.java#L551]
> object but not (overridden/extended) in
> [ServerEncryptionOptions.|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/config/EncryptionOptions.java#L600]
> Code is using the EncryptionOptions as the key in the
> [ConcurrentHashMap|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/security/SSLFactory.java#L84]
> in the SSLFactory.java. Hence technically we must have a equals/hashCode
> override in the ServerEncryptionOptions to account for fields that matter
> additionally (e.g. outbound_keystore/password).
> We discussed this over the [cassandra-dev slack
> channel|https://the-asf.slack.com/archives/CK23JSY2K/p1680118849081399] and
> it seems agreeable to make this change.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
