[
https://issues.apache.org/jira/browse/CASSANDRA-18428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17747165#comment-17747165
]
Maulin Vasavada commented on CASSANDRA-18428:
---------------------------------------------
For j17 unit tests on the CI above, I see below test failures, due to failure
to create certs. I guess that is as per discussed on some other thread due to
deprecated jdk classes.
{noformat}
Testcase:
testServerSocketShouldUseKeystore(org.apache.cassandra.security.SSLFactoryTest)-.jdk17:
Caused an ERROR
[junit-timeout] Could not initialize class
org.apache.cassandra.security.SSLFactoryTest
[junit-timeout] java.lang.NoClassDefFoundError: Could not initialize class
org.apache.cassandra.security.SSLFactoryTest
[junit-timeout] at
java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native
Method)
[junit-timeout] at
java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:77)
[junit-timeout] at
java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
[junit-timeout] at
java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:499)
[junit-timeout] at
java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:480)
[junit-timeout] Caused by: java.lang.ExceptionInInitializerError: Exception
java.lang.RuntimeException: failed to create test certs [in thread "main"]
[junit-timeout] at
org.apache.cassandra.security.SSLFactoryTest.<clinit>(SSLFactoryTest.java:70){noformat}
> Implement/override equals and hashCode methods in the ServerEncryptionOptions
> class
> -----------------------------------------------------------------------------------
>
> Key: CASSANDRA-18428
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18428
> Project: Cassandra
> Issue Type: Improvement
> Components: Local/Config
> Reporter: Maulin Vasavada
> Assignee: Maulin Vasavada
> Priority: Normal
> Labels: lhf
> Fix For: 5.x
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> We have {{equals and hashCode}} methods in
> [EncryptionOptions|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/config/EncryptionOptions.java#L551]
> object but not (overridden/extended) in
> [ServerEncryptionOptions.|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/config/EncryptionOptions.java#L600]
> Code is using the EncryptionOptions as the key in the
> [ConcurrentHashMap|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/security/SSLFactory.java#L84]
> in the SSLFactory.java. Hence technically we must have a equals/hashCode
> override in the ServerEncryptionOptions to account for fields that matter
> additionally (e.g. outbound_keystore/password).
> We discussed this over the [cassandra-dev slack
> channel|https://the-asf.slack.com/archives/CK23JSY2K/p1680118849081399] and
> it seems agreeable to make this change.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
