[
https://issues.apache.org/jira/browse/CASSANDRA-18428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17745512#comment-17745512
]
Maxim Muzafarov commented on CASSANDRA-18428:
---------------------------------------------
Yes, this sounds a bit confusing to me as well, but the checkstlye is skipped
for jdk11,jdk17 and only works for jdk8. This is related to the minimal
supported version (currently it is jdk8) of the project, so we should be under
it in most of the cases - that was the original idea. Personally, I use the
[sdkman|https://sdkman.io/] to switch between different versions.
Please also note that not all of the code styles from the code style guide
rules are checked by the checkstyle like the {{LeftCurlyCheck}}, for example, I
have tested the {{LeftCurlyCheck}} rule locally and it has found 843 violations
in production classes and 2056 in test classes, so it's a bit imprecise.
> Implement/override equals and hashCode methods in the ServerEncryptionOptions
> class
> -----------------------------------------------------------------------------------
>
> Key: CASSANDRA-18428
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18428
> Project: Cassandra
> Issue Type: Improvement
> Components: Local/Config
> Reporter: Maulin Vasavada
> Assignee: Maulin Vasavada
> Priority: Normal
> Labels: lhf
> Fix For: 5.x
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> We have {{equals and hashCode}} methods in
> [EncryptionOptions|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/config/EncryptionOptions.java#L551]
> object but not (overridden/extended) in
> [ServerEncryptionOptions.|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/config/EncryptionOptions.java#L600]
> Code is using the EncryptionOptions as the key in the
> [ConcurrentHashMap|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/security/SSLFactory.java#L84]
> in the SSLFactory.java. Hence technically we must have a equals/hashCode
> override in the ServerEncryptionOptions to account for fields that matter
> additionally (e.g. outbound_keystore/password).
> We discussed this over the [cassandra-dev slack
> channel|https://the-asf.slack.com/archives/CK23JSY2K/p1680118849081399] and
> it seems agreeable to make this change.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
