[ 
https://issues.apache.org/jira/browse/CASSANDRA-18696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17748435#comment-17748435
 ] 

Berenguer Blasi commented on CASSANDRA-18696:
---------------------------------------------

Apologies for the probably unnecessary +1 but I wanted to check a couple jmh I 
know of and their exact numbers and expectations. All LGTM +1


{noformat}
     [java] Benchmark                                    (diskRAMParam)  
(liveDTPcParam)  (sstableParam)  Mode  Cnt        Score        Error  Units
     [java] DeletionTimeDeSerBench.testE2EDeSerializeDT             RAM         
70PcLive              NC  avgt   15   790054.301 ±  17371.734  ns/op
     [java] DeletionTimeDeSerBench.testE2EDeSerializeDT             RAM         
70PcLive              OA  avgt   15   537364.490 ±  11376.957  ns/op
     [java] DeletionTimeDeSerBench.testE2EDeSerializeDT             RAM         
30PcLive              NC  avgt   15  1201853.555 ±   8361.631  ns/op
     [java] DeletionTimeDeSerBench.testE2EDeSerializeDT             RAM         
30PcLive              OA  avgt   15   955639.493 ±   8058.633  ns/op
     [java] DeletionTimeDeSerBench.testE2EDeSerializeDT            Disk         
70PcLive              NC  avgt   15  1384600.933 ±  57878.582  ns/op
     [java] DeletionTimeDeSerBench.testE2EDeSerializeDT            Disk         
70PcLive              OA  avgt   15   719772.522 ±  24638.764  ns/op
     [java] DeletionTimeDeSerBench.testE2EDeSerializeDT            Disk         
30PcLive              NC  avgt   15  1694409.156 ±  40679.844  ns/op
     [java] DeletionTimeDeSerBench.testE2EDeSerializeDT            Disk         
30PcLive              OA  avgt   15  1274244.014 ±  39696.821  ns/op
     [java] DeletionTimeDeSerBench.testE2ESerializeDT               RAM         
70PcLive              NC  avgt   15   495671.176 ±  12119.327  ns/op
     [java] DeletionTimeDeSerBench.testE2ESerializeDT               RAM         
70PcLive              OA  avgt   15   298808.073 ±   4842.600  ns/op
     [java] DeletionTimeDeSerBench.testE2ESerializeDT               RAM         
30PcLive              NC  avgt   15   662668.677 ±   5628.193  ns/op
     [java] DeletionTimeDeSerBench.testE2ESerializeDT               RAM         
30PcLive              OA  avgt   15   493528.208 ±  30317.138  ns/op
     [java] DeletionTimeDeSerBench.testE2ESerializeDT              Disk         
70PcLive              NC  avgt   15  1573535.262 ± 220634.296  ns/op
     [java] DeletionTimeDeSerBench.testE2ESerializeDT              Disk         
70PcLive              OA  avgt   15   523997.243 ±   3344.615  ns/op
     [java] DeletionTimeDeSerBench.testE2ESerializeDT              Disk         
30PcLive              NC  avgt   15  1771046.649 ± 170000.962  ns/op
     [java] DeletionTimeDeSerBench.testE2ESerializeDT              Disk         
30PcLive              OA  avgt   15  1009809.493 ± 128296.671  ns/op
     [java] DeletionTimeDeSerBench.testRawAlgReads                  RAM         
70PcLive              NC  avgt   15        0.451 ±      0.006  ns/op
     [java] DeletionTimeDeSerBench.testRawAlgReads                  RAM         
70PcLive              OA  avgt   15        0.447 ±      0.007  ns/op
     [java] DeletionTimeDeSerBench.testRawAlgReads                  RAM         
30PcLive              NC  avgt   15        0.447 ±      0.008  ns/op
     [java] DeletionTimeDeSerBench.testRawAlgReads                  RAM         
30PcLive              OA  avgt   15        0.444 ±      0.003  ns/op
     [java] DeletionTimeDeSerBench.testRawAlgReads                 Disk         
70PcLive              NC  avgt   15        0.449 ±      0.006  ns/op
     [java] DeletionTimeDeSerBench.testRawAlgReads                 Disk         
70PcLive              OA  avgt   15        0.446 ±      0.004  ns/op
     [java] DeletionTimeDeSerBench.testRawAlgReads                 Disk         
30PcLive              NC  avgt   15        0.452 ±      0.008  ns/op
     [java] DeletionTimeDeSerBench.testRawAlgReads                 Disk         
30PcLive              OA  avgt   15        0.444 ±      0.004  ns/op
     [java] DeletionTimeDeSerBench.testRawAlgWrites                 RAM         
70PcLive              NC  avgt   15        0.445 ±      0.004  ns/op
     [java] DeletionTimeDeSerBench.testRawAlgWrites                 RAM         
70PcLive              OA  avgt   15        0.448 ±      0.006  ns/op
     [java] DeletionTimeDeSerBench.testRawAlgWrites                 RAM         
30PcLive              NC  avgt   15        0.453 ±      0.005  ns/op
     [java] DeletionTimeDeSerBench.testRawAlgWrites                 RAM         
30PcLive              OA  avgt   15        0.451 ±      0.008  ns/op
     [java] DeletionTimeDeSerBench.testRawAlgWrites                Disk         
70PcLive              NC  avgt   15        0.443 ±      0.001  ns/op
     [java] DeletionTimeDeSerBench.testRawAlgWrites                Disk         
70PcLive              OA  avgt   15        0.451 ±      0.004  ns/op
     [java] DeletionTimeDeSerBench.testRawAlgWrites                Disk         
30PcLive              NC  avgt   15        0.454 ±      0.006  ns/op
     [java] DeletionTimeDeSerBench.testRawAlgWrites                Disk         
30PcLive              OA  avgt   15        0.453 ±      0.009  ns/op

{noformat}


> Update JMH
> ----------
>
>                 Key: CASSANDRA-18696
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-18696
>             Project: Cassandra
>          Issue Type: Task
>          Components: Build, Dependencies
>            Reporter: Ekaterina Dimitrova
>            Assignee: Ekaterina Dimitrova
>            Priority: Normal
>             Fix For: 5.x
>
>
> [~marianne-manaog] was trying to do some profiling and noticed illegal access 
> exceptions. Our version of JMH is from 2018; as per my recommendation, 
> upgrading to the latest one from the end of 2022 solved her problems. The new 
> version is tested with the JDK versions up to 17.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to