[
https://issues.apache.org/jira/browse/CASSANDRA-17992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17749047#comment-17749047
]
Jacek Lewandowski commented on CASSANDRA-17992:
-----------------------------------------------
[~e.dimitrova] I've removed those files from the PR and attached to this ticket
Answering your questions:
bq. Any particular reason why 4.1.94? There were two new versions in July.
Because when I started working on this ticket 4.1.94 was the newest visible
version in Sonatype
bq. I suggest any unrelated fixes - like the guava one, etc - to be added in a
separate commit and a description to the ticket
OK
bq. I am not a fan of suppressing the warnings for the deprecation of the
security manager. We need at least to open a ticket for visibility and
awareness, as that one will be its own work
OK, it is a compilation warning. When you run with JDK17 you get a plenty of
runtime warnings which cannot be suppressed. JDK didn't come up yet with any
other solution for intercepting {{System.exit}}. I'll open a ticket for fixing
this somehow on our end (I suppose we will have to provide an agent for that) -
https://issues.apache.org/jira/browse/CASSANDRA-18711
bq. Good catch on the change of Netty defaults. Would you like us to have a
follow-up ticket for testing and evaluating other defaults? (for the future,
maybe not even necessarily for this release)
Since we didn't explicitly set values for those defaults, testing and comparing
the performance with the old and new defaults would be good. Netty updated them
for a reason, and I'm not 100% sure if the right way of upgrading Netty is to
keep the old defaults unless we encounter failures during testing. In other
words - since we already know that the old defaults work, I'll create the
ticket to move to the Netty defaults providing that the tests pass and the
performance is not worse.
> Upgrade Netty on 5.0
> --------------------
>
> Key: CASSANDRA-17992
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17992
> Project: Cassandra
> Issue Type: Task
> Components: Dependencies
> Reporter: Ekaterina Dimitrova
> Assignee: Jacek Lewandowski
> Priority: Normal
> Fix For: 5.x
>
> Attachments: important-netty-inter-releases.md,
> netty-release-notes-filtered.md, netty-release-notes.md
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> I haven't been able to identify from the Netty docs which was the lowest
> version where JDK17 was added but we are about 40 versions behind in netty 4
> so I suspect we better update.
> -We need to consider there was an issue with class cast exceptions when
> building with JDK17 with newer versions of netty (the newest available in
> March 2022). For the record, we didn't see those when running CI on JDK8 and
> JDK11. We also need to carefully revise the changes between the netty
> versions. -->- CASSANDRA-18180
> Upgrading will cover also a fix in netty that was discussed in
> [this|https://the-asf.slack.com/archives/CK23JSY2K/p1665567660202989] ASF
> Slack thread.
> CC [~benedict] , [~aleksey]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
