[
https://issues.apache.org/jira/browse/CASSANDRA-17687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17749352#comment-17749352
]
Ekaterina Dimitrova edited comment on CASSANDRA-17687 at 7/31/23 8:37 PM:
--------------------------------------------------------------------------
I think it is time to check this one again.
Looking in trunk... it seems CASSANDRA-18255 broke the javadoc task but CI does
not catch it. I will produce a patch shortly to move this forward but I have
two additional things on my mind:
1) Why CI did not catch it? It seems we do not run javadoc and gendoc in CI
anymore. [~jlewandowski] , [~mck], was this intentional?
2) Shall we fix before the release the 100 javadoc errors we see when we run
the task or not? It seems like the macrodef create-javadoc was left long ago
with failonerror="false"
was (Author: e.dimitrova):
I think it is time to check this one again.
Looking in trunk... it seems CASSANDRA-18255 broke the javadoc task but CI does
not catch it. I will produce a patch shortly to move this forward but I have
two additional things on my mind:
1) Why CI did not catch it? It seems we do not run javadoc and gendoc in CI
anymore. [~jlewandowski] , [~mck], was this intentional?
2) Shall we fix before the release the 100 javadoc errors we see when we run
the task or not? It seems like the microdef create-javadoc was left long ago
with failonerror="false"
> Remove "--frames" option when generating javadoc
> ------------------------------------------------
>
> Key: CASSANDRA-17687
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17687
> Project: Cassandra
> Issue Type: Improvement
> Components: Build
> Reporter: Zili Chen
> Assignee: Zili Chen
> Priority: Normal
> Fix For: 5.x
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> JDK17 doesn't support this option and it seems not quite necessary. For
> forward compatibility I propose we can remove this option.
> Related JDK issue: [https://bugs.openjdk.org/browse/JDK-8215599]
> I volunteer to prepare a patch if this is in a good direction.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
