[
https://issues.apache.org/jira/browse/CASSANDRA-17687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17749862#comment-17749862
]
Ekaterina Dimitrova edited comment on CASSANDRA-17687 at 8/1/23 2:48 PM:
-------------------------------------------------------------------------
Thank you both!
{quote}I don't know why it was disabled. But it should work since we have that
in our build script.
{quote}
That is why I asked; quick grep in cassandra builds gets me this:
{code:java}
grep -r "javadoc" *
build-scripts/cassandra-test.sh: ant jar -Dno-checkstyle=true
-Drat.skip=true -Dant.gen-doc.skip=true -Djavadoc.skip=true
docker/build-rpms.sh:# javadoc target is broken in docker without this mkdir
docker/build-rpms.sh:mkdir -p ./build/javadoc
{code}
When I checked cassandra-test.sh, it seems this line was added in
CASSANDRA-18133, the bring in-tree scripts ticket.
I suggest we commit the current patch to fix the task and have two follow-up
tickets:
1) javadoc - do we need it? If yes, fix the errors. If no - remove it.
2) gen-doc - I suspect this was broken a long time ago - I believe
convert_yaml_to_rst.py does not exist since the migration to AsciiDoc.
was (Author: e.dimitrova):
Thank you both!
{quote}I don't know why it was disabled. But it should work since we have that
in our build script.
{quote}
That is why I asked; quick grep in cassandra builds gets me this:
{code:java}
grep -r "javadoc" *
build-scripts/cassandra-test.sh: ant jar -Dno-checkstyle=true
-Drat.skip=true -Dant.gen-doc.skip=true -Djavadoc.skip=true
docker/build-rpms.sh:# javadoc target is broken in docker without this mkdir
docker/build-rpms.sh:mkdir -p ./build/javadoc
{code}
When I checked cassandra-test.sh, it seems this line was added in
CASSANDRA-18133, the bring in-tree scripts ticket.
I suggest we commit to this PR and have two follow-up tickets:
1) javadoc - do we need it? If yes, fix the errors. If no - remove it.
2) gen-doc - I suspect this was broken a long time ago - I believe
convert_yaml_to_rst.py does not exist since the migration to AsciiDoc.
> Remove "--frames" option when generating javadoc
> ------------------------------------------------
>
> Key: CASSANDRA-17687
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17687
> Project: Cassandra
> Issue Type: Improvement
> Components: Build
> Reporter: Zili Chen
> Assignee: Zili Chen
> Priority: Normal
> Fix For: 5.x
>
> Attachments: signature.asc
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> JDK17 doesn't support this option and it seems not quite necessary. For
> forward compatibility I propose we can remove this option.
> Related JDK issue: [https://bugs.openjdk.org/browse/JDK-8215599]
> I volunteer to prepare a patch if this is in a good direction.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
