[
https://issues.apache.org/jira/browse/CASSANDRA-18466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17749457#comment-17749457
]
Jacek Lewandowski commented on CASSANDRA-18466:
-----------------------------------------------
I know this patch is looking good. My request for testing was more about
investigating the ways we can test that. The change was done in parsing the
command line options so we do not have to employ any machinery to verify it. I
was thinking about something like:
{code:java}
NodeProbe nodeProbe = mock(NodeProbe.class);
NodeProbeFactory customNodeProbeFactory = new NodeProbeFactory() {
// createXXX methods returns mocked nodeProbe
}
NodeTool nt = new NodeTool(customNodeProbeFactory, ...).execute(testArgs);
// check that nodeProbe.repairAsync(...) was called with appropriate options
{code}
> Paxos only repair is treated as an incremental repair
> -----------------------------------------------------
>
> Key: CASSANDRA-18466
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18466
> Project: Cassandra
> Issue Type: Bug
> Components: Consistency/Repair
> Reporter: Andrew
> Assignee: Ningzi Zhan
> Priority: Normal
> Labels: lhf
> Fix For: 4.1.x, 5.x
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Paxos only repair tries to continue or is treated as an incremental repair.
> This happened on 4.1.0 and 4.1.1 when trying to run repair in preparation for
> enabling paxos_state_purging. The repair was in preparation mode triggered
> multiple anti-compactions on the nodes. Running the command with --full
> behaves in the expected way, ie. only the paxos data is repaired and it's
> finished within a few seconds.
> {code:java}
> nodetool repair --paxos-only // This does not behave as expected, does it
> complete quickly and seems to be waiting on anticompactions
> {code}
> {code:java}
> nodetool repair --full --paxos-only // Completes within a few seconds as
> expected
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
