[ 
https://issues.apache.org/jira/browse/CASSANDRA-18466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17757758#comment-17757758
 ] 

Maxwell Guo commented on CASSANDRA-18466:
-----------------------------------------

Hi [~brandon.williams], [~jlewandowski], [~qannap] 
1.I have  some comments 
[here|https://github.com/apache/cassandra/pull/2531#pullrequestreview-1590578163],
 can you take a look ?
2.Besides, can we add some t jvm-dtest,like [PaxosRepair2Test 
title|https://github.com/apache/cassandra/blob/trunk/test/distributed/org/apache/cassandra/distributed/test/PaxosRepair2Test.java]
 here, or just add some cases in this class? So we can make a e2e test .  But I 
do not find a good way to  verify the result is a paxos repair or not ~~~
3.These ci are not all green.


> Paxos only repair is treated as an incremental repair
> -----------------------------------------------------
>
>                 Key: CASSANDRA-18466
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-18466
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Consistency/Repair
>            Reporter: Andrew
>            Assignee: Ningzi Zhan
>            Priority: Normal
>              Labels: lhf
>             Fix For: 4.1.x, 5.0.x, 5.x
>
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> Paxos only repair tries to continue or is treated as an incremental repair. 
> This happened on 4.1.0 and 4.1.1 when trying to run repair in preparation for 
> enabling paxos_state_purging. The repair was in preparation mode triggered 
> multiple anti-compactions on the nodes. Running the command with --full 
> behaves in the expected way, ie. only the paxos data is repaired and it's 
> finished within a few seconds.
> {code:java}
> nodetool repair --paxos-only // This does not behave as expected, does it 
> complete quickly and seems to be waiting on anticompactions
> {code}
> {code:java}
> nodetool repair --full --paxos-only // Completes within a few seconds as 
> expected
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to