[
https://issues.apache.org/jira/browse/CASSANDRA-18688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17752919#comment-17752919
]
Ekaterina Dimitrova commented on CASSANDRA-18688:
-------------------------------------------------
Overall LGTM, I left just two small comments on the PR for your consideration:
* suggestion to change a bit the error message
* I think we should use the JVM11 options files for versions between J11 and
J17 and the J17 files for anything 17 and beyond 17.
* We need similar changes to be applied to tools/bin/cassandra.in.sh (similar
to bin/cassandra.in.sh)
Sanity check CI run stared here, to ensure I did not miss anything:
[https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=18688]
> Limit Java runtime in 5.0 to JDK 11 and 17 in scripts; add a flag to opt out
> of that
> ------------------------------------------------------------------------------------
>
> Key: CASSANDRA-18688
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18688
> Project: Cassandra
> Issue Type: Task
> Components: Build
> Reporter: Ekaterina Dimitrova
> Assignee: shylaja kokoori
> Priority: Normal
> Fix For: 5.1.x
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Currently, we limit our users from building with non-default Java versions in
> build.xml.
> They can easily hack build.xml for test purposes with different versions.
> Cassandra–5.0 will be run on JDK11 and JDK17, but on startup, we do not limit
> people to those two, but only to everything >= 11. We should also put an
> upper limit of 17 in our Cassandra startup scripts. We can also add a flag to
> opt-out if someone wants to test with newer versions.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
