[ https://issues.apache.org/jira/browse/CASSANDRA-18725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17758767#comment-17758767 ]
Jon Meredith commented on CASSANDRA-18725: ------------------------------------------ Reviewing test failures, I don't think any are due to the changes as it should only affect in-jvm tests and those failures are pre-existing. {{code}} *3.11* j8_jvm_dtests testReprepareMixedVersionWithoutReset - hashcollision j8_jvm_upgrade_dtests testDropCompactWithClusteringAndValueColumn - cannot achieve consistency testDropCompactWithClusteringAndValueColumnWithDeletesAndWrites - unavailable exception org.apache.cassandra.distributed.upgrade.MixedModeReadTest - unavailable exception *4.0* j11_dtest test_move_backwards_between_and_cleanup - startup timeout j11_jvm_dtests org.apache.cassandra.distributed.test.FailingRepairTest:testFailingMessage - test timeout j11_unit_tests testPagingWithClustering j8_jvm_dtests timeout in org.apache.cassandra.distributed.test.FailingRepairTest j8_jvm_upgrade_dtests org.apache.cassandra.distributed.upgrade.MixedModeReadTest -- cannot achieve consistency *4.1* j11_dtests ttl_test.py::TestTTL::test_insert_ttl_has_priority_on_defaut_ttl j8_jvm_upgrade_dtests org.apache.cassandra.distributed.upgrade.MixedModeReadTest -- cannot achieve consistency j8_upgrade_dtests TestProtoV3Upgrade_AllVersions_RandomPartitioner_EndsAt_Trunk_HEAD.test_parallel_upgrade_with_internode_ssl j8_upgrade_dtests TestUpgrade_indev_4_1_x_To_indev_trunk.test_bootstrap_multidc *5.0* j11_dtests_vnode TestSecondaryIndexes.test_failing_manual_rebuild_index *trunk* org.apache.cassandra.distributed.upgrade.MixedModeAvailabilityV30AllOneTest -- failing before commit {{code}} > IsolatedJMX should not release all TCPEndpoints on instance shutdown > -------------------------------------------------------------------- > > Key: CASSANDRA-18725 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18725 > Project: Cassandra > Issue Type: Improvement > Components: Test/dtest/java > Reporter: Doug Rohrer > Assignee: Doug Rohrer > Priority: Normal > Fix For: 3.11.x, 4.0.x, 4.1.x, 5.0.x, 5.x > > Time Spent: 2.5h > Remaining Estimate: 0h > > In the original implementation of the JMX feature, we fixed some memory leaks > by clearing some internal state in Java’s TCPEndpoint. However, that > implementation was overly aggressive and cleared the whole map, vs. just > removing the endpoints created by the individual instances. This causes > issues when you remove a node from the cluster (as all of the endpoints are > cleared, not just the ones in use by that instance). > > In stead, we should check if the endpoint was created by the instance in > question and only remove it if it was. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org