[ https://issues.apache.org/jira/browse/CASSANDRA-18725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17770375#comment-17770375 ]
Andres de la Peña commented on CASSANDRA-18725: ----------------------------------------------- None of the above CircleCI runs contains the repeated runs of the modified files ({{ResourceLeakTest}}, {{JMXFeatureTest}} and {{JMXGetterCheckTest}}). I think this is due to a bug in the non-public script used to generate the CircleCI config file. Those repeated runs can be generated with the project's [{{.circleci/generate.sh}}|https://github.com/apache/cassandra/blob/trunk/.circleci/generate.sh] script. The absence of repeated runs can be easily detected by looking at the CI results, in the workflow view. If the patch contains any changes on tests there should be jobs named with the {{_repeat}} suffix. One can also check whether the pushed {{.circleci/config.yml}} file contains the names of relevant tests. > IsolatedJMX should not release all TCPEndpoints on instance shutdown > -------------------------------------------------------------------- > > Key: CASSANDRA-18725 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18725 > Project: Cassandra > Issue Type: Improvement > Components: Test/dtest/java > Reporter: Doug Rohrer > Assignee: Doug Rohrer > Priority: Normal > Fix For: 3.11.17, 4.0.12, 4.1.4, 5.0-alpha, 5.x > > Time Spent: 3h 20m > Remaining Estimate: 0h > > In the original implementation of the JMX feature, we fixed some memory leaks > by clearing some internal state in Java’s TCPEndpoint. However, that > implementation was overly aggressive and cleared the whole map, vs. just > removing the endpoints created by the individual instances. This causes > issues when you remove a node from the cluster (as all of the endpoints are > cleared, not just the ones in use by that instance). > > In stead, we should check if the endpoint was created by the instance in > question and only remove it if it was. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org