[
https://issues.apache.org/jira/browse/CASSANDRA-18832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17763863#comment-17763863
]
Ekaterina Dimitrova commented on CASSANDRA-18832:
-------------------------------------------------
{quote}I don't think those lines apply, it's more than there's no DSE code
calling the `get_supported_jdk_versions` function indirectly anywhere. As you
say, we should have heard about it already.
{quote}
(y) Exactly what I meant, not affected, that method is not called in DSE
related code. I think we should remove this comment -
https://github.com/riptano/ccm/compare/master...thelastpickle:ccm:mck/5.0-alpha1#diff-0999a90fd83b66b6840af0bbd8afd1ebd9648e135b0665692fa0f523325a1058R926
{quote}No. CI won't run with the wrong JDKs. If you manually try to start CCM
with the wrong JDK the C* start scripts will fail.
{quote}
Yeah, agreed, the cost will be covered only by patches working on updating JDKs
if there is a bug. That should be caught before reaching post-commit CI.
[https://github.com/apache/cassandra-builds/commit/7e205252a001b9316efe98da329d26e3b62c1df9#diff-94d145ce56fae0df90d78708f55a384aa886863e21178859ef715a3eb491d504R283]
---> we might want to add a step here for upgrade_through_versions
{quote}From my memories, we had to update more places than just the
upgrade_manifest.
For reference - CASSANDRA-17869
{quote}
This was addressed and green CI is published on the PR
+1, the two comments I made can be addressed on commit:
1)
{quote}bq. I think we should remove this comment
{quote}
2)
{quote}bq. we might want to add a step in the instructions here for
upgrade_through_versions
{quote}
> Add 5.0-alpha1 to cassandra-dtest upgrade_manifest.py
> -----------------------------------------------------
>
> Key: CASSANDRA-18832
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18832
> Project: Cassandra
> Issue Type: Task
> Components: Test/dtest/python
> Reporter: Michael Semb Wever
> Assignee: Michael Semb Wever
> Priority: High
> Fix For: 5.0-alpha, 5.x
>
>
> With the release of 5.0-alpha1, that version can be added to the
> dtest-upgrades.
> Unfortunately ccm has a bug in it where it cannot determine the supported
> jdks for binary installs of 5+
> Patches:
> -
> https://github.com/riptano/ccm/compare/master...thelastpickle:ccm:mck/5.0-alpha1
> -
> https://github.com/apache/cassandra-dtest/compare/trunk...thelastpickle:cassandra-dtest:mck/5.0-alpha1-bump
> CI demonstrating the failure
> - 5.0
> https://app.circleci.com/pipelines/github/michaelsembwever/cassandra/242/workflows/8eee6b06-46d5-4d42-b137-b696b63a190c/jobs/18955
> - trunk
> https://app.circleci.com/pipelines/github/michaelsembwever/cassandra/243/workflows/d5a12c3d-04d2-4de2-a88f-3c8cae09c341/jobs/18956
> CI demonstrating the fix
> - 5.0
> https://app.circleci.com/pipelines/github/michaelsembwever/cassandra/244/workflows/0d0484c0-82c1-49aa-9656-8d0eb6d6648b/jobs/19051
> - trunk
> https://app.circleci.com/pipelines/github/michaelsembwever/cassandra/245/workflows/c6d2963b-6b2a-4b33-b721-b56e84627c48/jobs/19146
> Note this does not fix DSE versions, which was already broken.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
