[
https://issues.apache.org/jira/browse/CASSANDRA-18781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17764471#comment-17764471
]
Runtian Liu commented on CASSANDRA-18781:
-----------------------------------------
[~smiklosovic] I've investigated the error you pointed out. I think the error
is not caused by the changed added by this pull request. The error is
sstableloader cannot handle stream failed message.
When
[closeSession|https://github.com/instaclustr/cassandra/blob/trunk/src/java/org/apache/cassandra/streaming/StreamSession.java#L527]
function is called,
[https://github.com/instaclustr/cassandra/blob/trunk/src/java/org/apache/cassandra/streaming/StreamSession.java#L545]
will trigger the releaseReferences function of sstableloader because of
onFailure is triggered.
However,
[https://github.com/instaclustr/cassandra/blob/trunk/src/java/org/apache/cassandra/streaming/StreamSession.java#L551]
is not run when the onFailure function is called. The tasks are not aborted so
we got the reference issue.
I added a
[commit|https://github.com/apache/cassandra/pull/2649/commits/65a2325e9f47c3681b026c56a92d1f2a6633e479]
in the pull request. it moved
{code:java}
streamResult.handleSessionComplete(this);{code}
down after the abort tasks are finished.
I think this is a different issue. Maybe we can create another ticket to handle
stream failure better. Let me know what do you think.
> Add the ability to disable bulk loading of SSTables on a node
> -------------------------------------------------------------
>
> Key: CASSANDRA-18781
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18781
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/bulk load
> Reporter: Runtian Liu
> Assignee: Runtian Liu
> Priority: Normal
> Fix For: 5.x
>
> Time Spent: 2h
> Remaining Estimate: 0h
>
> Currently, Cassandra database users can use sstableloader to bulk load data
> into Cassandra. However, for a Cassandra operator, there is no way to
> forcibly block this behavior. Additionally, there is no metric indicating
> whether the bulk load is being used on the server side. If a client is using
> sstableloader, they will also need to upgrade the sstableloader code to the
> new major version. This lack of control and visibility can become a blocker
> during a major version upgrade.
>
> 1. Can we add a config to disable bulk load feature? Or it falls into
> https://issues.apache.org/jira/browse/CASSANDRA-8303
> 2. Can we add metrics for bulk load used on server end?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
