[ 
https://issues.apache.org/jira/browse/CASSANDRA-18742?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Miklosovic updated CASSANDRA-18742:
------------------------------------------
    Status: Patch Available  (was: In Progress)

pr https://github.com/apache/cassandra/pull/2699
dtest pr https://github.com/apache/cassandra-dtest/pull/234/files

j17 pre-commit to see where we are at 

https://app.circleci.com/pipelines/github/instaclustr/cassandra/3154/workflows/abf98f42-b2b3-4dfd-ab4b-37bd4c24e102

Failures are just flakes, one test all over again basically.

[~aleksey] would you mind to give it a shot?

I ll do the PR for trunk after this is reviewed, should be applied cleanly.

I have not removed crc_check_chance in this patch. The removal of that is more 
involved and I want to focus on its removal in a separate ticket. 

> Remove crcCheckChance and deprecated options in CompressionParams
> -----------------------------------------------------------------
>
>                 Key: CASSANDRA-18742
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-18742
>             Project: Cassandra
>          Issue Type: Task
>          Components: Feature/Compression
>            Reporter: Stefan Miklosovic
>            Assignee: Stefan Miklosovic
>            Priority: Normal
>             Fix For: 5.x
>
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> These should go away (1). They were deprecated like 8 years ago in 
> CASSANDRA-9712 and CASSANDRA-9839.
> We should also remove this (2). That is a little bit more tricky but nothing 
> special I would say ...
> (1) 
> https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/schema/CompressionParams.java#L86-L88
> (2) 
> https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/schema/CompressionParams.java#L96-L97



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to