[ 
https://issues.apache.org/jira/browse/CASSANDRA-18870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17767118#comment-17767118
 ] 

Brandon Williams commented on CASSANDRA-18870:
----------------------------------------------

bq. The test case's catch body do not doing the exception message validation 
.So no matter the cql is illegal or not , the test will still pass.

I see, good catch.

Unfortunately If you rebased I don't think it helped, it's still got commits 
from CASSANDRA-17698

> Invalid ut check for CreateTableValidationTest
> ----------------------------------------------
>
>                 Key: CASSANDRA-18870
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-18870
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Test/unit
>            Reporter: Maxwell Guo
>            Assignee: Maxwell Guo
>            Priority: Normal
>             Fix For: 5.x
>
>
> https://github.com/apache/cassandra/blob/trunk/test/unit/org/apache/cassandra/schema/CreateTableValidationTest.java#L40
> This test case testInvalidBloomFilterFPRatio()  makes no sense and cannot 
> achieve the desired purpose.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to