[
https://issues.apache.org/jira/browse/CASSANDRA-18870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17767570#comment-17767570
]
Brandon Williams commented on CASSANDRA-18870:
----------------------------------------------
Looks good to me. We don't need to do a full pre-commit here but we do need to
multiplex this test to make sure no flakiness was introduced (even though I
doubt it.)
||Branch||CI||
|[trunk|https://github.com/driftx/cassandra/tree/CASSANDRA-18870-trunk]|[utest
repeat|https://app.circleci.com/pipelines/github/driftx/cassandra/1302/workflows/f9de74ee-5423-44bd-a244-5298cb899eed/jobs/54703]|
It's green, +1 from me.
> Invalid ut check for CreateTableValidationTest
> ----------------------------------------------
>
> Key: CASSANDRA-18870
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18870
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
> Reporter: Maxwell Guo
> Assignee: Maxwell Guo
> Priority: Normal
> Fix For: 5.x
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> https://github.com/apache/cassandra/blob/trunk/test/unit/org/apache/cassandra/schema/CreateTableValidationTest.java#L40
> This test case testInvalidBloomFilterFPRatio() makes no sense and cannot
> achieve the desired purpose.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
