5 commented on code in PR #15:
URL:
https://github.com/apache/cassandra-analytics/pull/15#discussion_r1332213687
##########
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/CassandraContext.java:
##########
@@ -96,4 +100,14 @@ protected BulkSparkConf conf()
{
return conf;
}
+
+ // Startup Validation
+
+ @Override
+ public void startupValidate()
+ {
+ StartupValidator.instance().register(new
SidecarValidation(sidecarClient));
+ StartupValidator.instance().register(new
CassandraValidation(sidecarClient));
+ StartupValidator.instance().perform();
Review Comment:
Current implementation serves several purposes: first, we get all validation
logic grouped together and easy to discover (unlike having many separate
validation calls in many different places); second, we register additional
validations at other places as well (see SSL/KeyStore/TrustStore validations,
for example); third, we enable library users to define and register their own
validations (which we ourselves use in our internal version of the library).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
