yifan-c commented on code in PR #15:
URL:
https://github.com/apache/cassandra-analytics/pull/15#discussion_r1332023979
##########
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/data/CassandraDataLayer.java:
##########
@@ -639,6 +644,16 @@ public CassandraRing
createCassandraRingFromRing(Partitioner partitioner,
return new CassandraRing(partitioner, keyspace, replicationFactor,
instances);
}
+ // Startup Validation
+
+ @Override
+ public void startupValidate()
+ {
+ StartupValidator.instance().register(new SidecarValidation(sidecar));
+ StartupValidator.instance().register(new CassandraValidation(sidecar));
+ StartupValidator.instance().perform();
+ }
Review Comment:
Let me clarify.
The register and perform design is unnecessary, as commented in
https://github.com/apache/cassandra-analytics/pull/15#discussion_r1330931869
I agree that the validation should be performed eagerly.
In the code, it looks like this.
```java
{
new SidecarValidation(sidecar).validate();
new CassandraValidation(sidecar).validate();
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
