[
https://issues.apache.org/jira/browse/CASSANDRA-3154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jonathan Ellis updated CASSANDRA-3154:
--------------------------------------
Attachment: 3154.txt
I'd rather get rid of that code. It's not useful because
- for leveled compactions, you are effectively guaranteed that once you have
more than a couple sstables, you'll never compact all sstables at once
- for non-leveled compactions, you have a small enough number of sstables that
isKeyInRemainingSSTables is fine without adding additional optimization for the
"major" case
This patch gets rid of isMajor, and additionally renames CompactionType to
OperationType to better reflect the "compaction" stage's role as generic
background IO manager.
> Bad equality check in ColumnFamilyStore.isCompleteSSTables()
> ------------------------------------------------------------
>
> Key: CASSANDRA-3154
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3154
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.0
> Reporter: Tupshin Harper
> Assignee: Tupshin Harper
> Fix For: 1.0
>
> Attachments: 3154.txt, CASSANDRA-3154.diff
>
>
> The equality check in isCompleteSSTables() always fails because it tries to
> call equals() with a Set and a List. This might result in failure to purge
> tombstones in some cases.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
