[ 
https://issues.apache.org/jira/browse/CASSANDRA-3154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13100470#comment-13100470
 ] 

Benjamin Coverston commented on CASSANDRA-3154:
-----------------------------------------------

Patch is good.
+1 Getting rid of isMajor makes the logic behind the determination of the 
compaction operation much cleaner.

> Bad equality check in ColumnFamilyStore.isCompleteSSTables()
> ------------------------------------------------------------
>
>                 Key: CASSANDRA-3154
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3154
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.0
>            Reporter: Tupshin Harper
>            Assignee: Tupshin Harper
>            Priority: Minor
>             Fix For: 1.0
>
>         Attachments: 3154.txt, CASSANDRA-3154.diff
>
>
> The equality check in isCompleteSSTables() always fails because it tries to 
> call equals() with a Set and a List. This might result in failure to purge 
> tombstones in some cases.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to