[
https://issues.apache.org/jira/browse/CASSANDRA-18757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17788730#comment-17788730
]
Branimir Lambov commented on CASSANDRA-18757:
---------------------------------------------
How about splitting this into separate tests for the 4 cases? I.e. have the
four calls in {{testIgnoreOverlaps}} run in separate {{@Test}}-annotated
methods?
> UnifiedCompactionTask is incorrectly setting keepOriginals
> ----------------------------------------------------------
>
> Key: CASSANDRA-18757
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18757
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Compaction
> Reporter: Branimir Lambov
> Assignee: Ethan Brown
> Priority: Normal
> Fix For: 5.0-beta, 5.x
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> {code:java}
> super(cfs, txn, gcBefore,
> strategy.getController().getIgnoreOverlapsInExpirationCheck());{code}
> in {{UnifiedCompactionTask}} is calling the base constructor
> {code:java}
> public CompactionTask(ColumnFamilyStore cfs, LifecycleTransaction txn, long
> gcBefore, boolean keepOriginals)
> {code}
> which can set {{keepOriginals}} to true when it should not be.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
