[
https://issues.apache.org/jira/browse/CASSANDRA-18757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17786650#comment-17786650
]
Stefan Miklosovic commented on CASSANDRA-18757:
-----------------------------------------------
[~ethan.brown] ok so please add one. As I read it, you do not seem to object
the idea. If it is not in beta1 it can be still added later, in rc1 or
something like that ... If you made that test the next week that would be
great. Nowhere to hurry, let's just do this "properly".
> UnifiedCompactionTask is incorrectly setting keepOriginals
> ----------------------------------------------------------
>
> Key: CASSANDRA-18757
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18757
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Compaction
> Reporter: Branimir Lambov
> Assignee: Ethan Brown
> Priority: Normal
> Fix For: 5.0-beta1, 5.x
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> {code:java}
> super(cfs, txn, gcBefore,
> strategy.getController().getIgnoreOverlapsInExpirationCheck());{code}
> in {{UnifiedCompactionTask}} is calling the base constructor
> {code:java}
> public CompactionTask(ColumnFamilyStore cfs, LifecycleTransaction txn, long
> gcBefore, boolean keepOriginals)
> {code}
> which can set {{keepOriginals}} to true when it should not be.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
