[ 
https://issues.apache.org/jira/browse/CASSANDRA-16418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17793600#comment-17793600
 ] 

Jacek Lewandowski commented on CASSANDRA-16418:
-----------------------------------------------

bq. I think that check was deemed unnecessary after a new check was added to 
StorageService.forceKeyspaceCleanup to prevent starting cleanup when there are 
pending ranges (ie. when a node is joining).

[~paulo] - it looks ok from the user point of view. However, from the API pov 
{{CompactionManager.performCleanup}} can be now called anytime - I think it was 
important precondition for that method - wouldn't be good to keep it there, 
just changing the condition to check pending ranges rather than joining status?


> Unsafe to run nodetool cleanup during bootstrap or decommission
> ---------------------------------------------------------------
>
>                 Key: CASSANDRA-16418
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-16418
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Consistency/Bootstrap and Decommission
>            Reporter: James Baker
>            Assignee: Lindsey Zurovchak
>            Priority: Normal
>             Fix For: 4.0.8, 4.1.1, 5.0-alpha1, 5.0
>
>          Time Spent: 3h 20m
>  Remaining Estimate: 0h
>
> What we expected: Running a cleanup is a safe operation; the result of 
> running a query after a cleanup should be the same as the result of running a 
> query before a cleanup.
> What actually happened: We ran a cleanup during a decommission. All the 
> streamed data was silently deleted, the bootstrap did not fail, the cluster's 
> data after the decommission was very different to the state before.
> Why: Cleanups do not take into account pending ranges and so the cleanup 
> thought that all the data that had just been streamed was redundant and so 
> deleted it. We think that this is symmetric with bootstraps, though have not 
> verified.
> Not sure if this is technically a bug but it was very surprising (and 
> seemingly undocumented) behaviour.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to