[
https://issues.apache.org/jira/browse/CASSANDRA-14572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17797951#comment-17797951
]
Maxim Muzafarov commented on CASSANDRA-14572:
---------------------------------------------
[~djoshi], [~cnlwsu], [~smiklosovic]
Hi all, I've prepared the patch, all tests, documentation and changes are
included. Please, take a look.
https://github.com/apache/cassandra/pull/2958/files
The discussion with design point is on the ML here:
https://lists.apache.org/thread/t49xyfkr2tfv2j6717hrg28fnycfkph9
I run the CI to make sure I haven't missed anything:
https://app.circleci.com/pipelines/github/Mmuzaf/cassandra/527/workflows/4e6866ed-5ce4-46ee-8cd4-fc04532e4f03
In addition, I'd like to mention that I've used an annotation processor to
prepare some auto-generated classes. I know that in some of the cases the
annotation processor can look scary and seem like an overkill, so we can remove
it and commit these classes directly to the source code, keeping in mind that
they can be generated. If we are not going to create new virtual tables often,
then this makes sense.
> Expose all table metrics in virtual table
> -----------------------------------------
>
> Key: CASSANDRA-14572
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14572
> Project: Cassandra
> Issue Type: New Feature
> Components: Legacy/Observability, Observability/Metrics
> Reporter: Chris Lohfink
> Assignee: Maxim Muzafarov
> Priority: Low
> Labels: virtual-tables
> Fix For: 5.x
>
> Attachments: systemv_views.metrics_dropped_message.png
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> While we want a number of virtual tables to display data in a way thats great
> and intuitive like in nodetool. There is also much for being able to expose
> the metrics we have for tooling via CQL instead of JMX. This is more for the
> tooling and adhoc advanced users who know exactly what they are looking for.
> *Schema:*
> Initial idea is to expose data via {{((keyspace, table), metric)}} with a
> column for each metric value. Could also use a Map or UDT instead of the
> column based that can be a bit more specific to each metric type. To that end
> there can be a {{metric_type}} column and then a UDT for each metric type
> filled in, or a single value with more of a Map<Text, Text> style. I am
> purposing the column type though as with {{ALLOW FILTERING}} it does allow
> more extensive query capabilities.
> *Implementations:*
> * Use reflection to grab all the metrics from TableMetrics (see:
> CASSANDRA-7622 impl). This is easiest and least abrasive towards new metric
> implementors... but its reflection and a kinda a bad idea.
> * Add a hook in TableMetrics to register with this virtual table when
> registering
> * Pull from the CassandraMetrics registery (either reporter or iterate
> through metrics query on read of virtual table)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
