[
https://issues.apache.org/jira/browse/CASSANDRA-19104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17798657#comment-17798657
]
Leo Toff commented on CASSANDRA-19104:
--------------------------------------
[~smiklosovic] thank you for reviewing the changes and merging them in. It
really is quite simple, I'd love to step up my game, but I have to say that
it's not 100% clear how to do that.
I'll start working on the second PR in the series which is about making
human-readable output default in Nodetool.
PRs in this Jira:
# Format space / memory numbers using KiB/MiB/GiB PR#2977
# Make human-readable format default TODO
# Implement thousands separators MAYBE
# Refactoring TODO
## Convert "out.printf(indent + ...)" to "out.printf(%s ..., indent ...)" in
TableStatsPrinter where printf format specifiers are used (see Stefan's comment
in PR#2977)
## Move formatting from the Holder class to the Printer class (from
TableStatsHolder to TableStatsPrinter)
## Consider renaming "formatMemory" (and other mentions of "memory") to
"formatDataSize" across TableStatsPrinter, TableStatsHolder, and FBUtilities
> Standardize tablestats formatting and data units
> ------------------------------------------------
>
> Key: CASSANDRA-19104
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19104
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/nodetool
> Reporter: Brad Schoening
> Assignee: Leo Toff
> Priority: Normal
> Fix For: 5.x
>
> Time Spent: 4h 10m
> Remaining Estimate: 0h
>
> Tablestats reports output in plaintext, JSON or YAML. The human readable
> output currently has a mix of KiB, bytes with inconsistent spacing
> Simplify and default output to 'human readable'. Machine readable output is
> available as an option and the current mixed output formatting is neither
> friendly for human or machine reading and can be replaced.
> !image-2023-11-27-13-49-14-247.png!
> *Not a goal now (consider a follow up Jira):*
> Fix inconsistencies with KiB/MiB/GiB and KB/MB/GB formatting:
> * gcstats - uses MB
> * getcompactionthroughput - uses MB/s
> * getstreamthroughput - uses MB/s
> * info - uses MiB/GiB
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
