[
https://issues.apache.org/jira/browse/CASSANDRA-19104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17794886#comment-17794886
]
Leo Toff commented on CASSANDRA-19104:
--------------------------------------
[~bschoeni] [~stefan.miklosovic] The first PR is out
[https://github.com/apache/cassandra/pull/2977] Please review when you get a
chance. It takes care of the space and memory formatting.
I'm planning to break up this Jira into the following PRs:
# Format space / memory numbers using KiB/MiB/GiB with three significant
digits PR#2977
# Make human-readable format default
# Implement thousands separators
# Refactoring: move formatting from the Holder class to the Printer class
(from TableStatsHolder to TableStatsPrinter)
Question regarding #3: Do we want to localize thousands separators? That is
commas for North America and dots for Europe. If yes, do we want to localize
for the Indian subcontinent (example `1,00,00,000`) and for China and Japan
(example `1,0000,0000`)?
> Standardize tablestats formatting and data units
> ------------------------------------------------
>
> Key: CASSANDRA-19104
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19104
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/nodetool
> Reporter: Brad Schoening
> Assignee: Leo Toff
> Priority: Normal
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Tablestats reports output in plaintext, JSON or YAML. The human readable
> output currently has a mix of KiB, bytes with inconsistent spacing
> Simplify and default output to 'human readable'. Machine readable output is
> available as an option and the current mixed output formatting is neither
> friendly for human or machine reading and can be replaced.
> !image-2023-11-27-13-49-14-247.png!
> *Not a goal now (consider a follow up Jira):*
> Fix inconsistencies with KiB/MiB/GiB and KB/MB/GB formatting:
> * gcstats - uses MB
> * getcompactionthroughput - uses MB/s
> * getstreamthroughput - uses MB/s
> * info - uses MiB/GiB
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
