[
https://issues.apache.org/jira/browse/CASSANDRA-18813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17808823#comment-17808823
]
Ekaterina Dimitrova commented on CASSANDRA-18813:
-------------------------------------------------
I just made a final pass, focused on whether any changes affected the patch
after the big rebases. I did not find any conflicts which would have changed
the code and required attention. If I haven't missed anything that you may
point out to me to check - +1
I also looked into the CI results:
I haven't found anything about this failure -
org.apache.cassandra.distributed.test.SnapshotsTest, but I do not think it can
relate to the patch. I suggest we do a repeated run against trunk and open a
ticket for the community to check this one.
- test-cassandra.testtag_IS_UNDEFINED - CASSANDRA-19279
- jvm tests failing with OOM - CASSANDRA-19279
- testDropListAndAddListWithSameName-oa_jdk17 - CASSANDRA-18360
> Simplify the bind marker and Term logic
> ---------------------------------------
>
> Key: CASSANDRA-18813
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18813
> Project: Cassandra
> Issue Type: Improvement
> Components: CQL/Interpreter
> Reporter: Benjamin Lerer
> Assignee: Benjamin Lerer
> Priority: Normal
> Fix For: 5.x
>
> Time Spent: 8.5h
> Remaining Estimate: 0h
>
> The current logic around {{Term}} and {{Terms}} classes is confusing
> specially with {{MultiItemTerminal}} and {{MultiColumnRaw}} that are used to
> handle different use cases that could be handled simply with the {{Term}}
> interface.
> On top of that IN marker add to the confusion because the are represented as
> single Term where in practice they are a set of terms. Representing them as a
> {{Terms}} could simplify the way we handle IN restrictions.
> The goal of this ticket is:
> * to refactor the {{Term}} and {{Terms}} interfaces to simplify the logic
> * Represents IN bind marker as {{Terms}} instead of having 2 different
> representations (a list of terms and a single {{MultiItemTerminal}}.
> * Simplify the {{AbstractMarker}} hierachy
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
