[
https://issues.apache.org/jira/browse/CASSANDRA-18813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17809565#comment-17809565
]
Andres de la Peña commented on CASSANDRA-18813:
-----------------------------------------------
The last changes look good to me, +1.
Regarding the failure of {{{}SnapshotsTest{}}}, I haven't been able to
reproduce it with the multiplexer, neither [in the base
branch|https://app.circleci.com/pipelines/github/adelapena/cassandra/3398/workflows/cd28d535-15c5-4ad6-9012-782d5fa9583f]
nor [in the patched
branch|https://app.circleci.com/pipelines/github/adelapena/cassandra/3399/workflows/f3dc74ed-9796-4cc3-95bc-d2edc026af52].
I cannot see how it could be related to the changes, so I'd say we merge this
and keep an eye on it.
> Simplify the bind marker and Term logic
> ---------------------------------------
>
> Key: CASSANDRA-18813
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18813
> Project: Cassandra
> Issue Type: Improvement
> Components: CQL/Interpreter
> Reporter: Benjamin Lerer
> Assignee: Benjamin Lerer
> Priority: Normal
> Fix For: 5.x
>
> Time Spent: 8.5h
> Remaining Estimate: 0h
>
> The current logic around {{Term}} and {{Terms}} classes is confusing
> specially with {{MultiItemTerminal}} and {{MultiColumnRaw}} that are used to
> handle different use cases that could be handled simply with the {{Term}}
> interface.
> On top of that IN marker add to the confusion because the are represented as
> single Term where in practice they are a set of terms. Representing them as a
> {{Terms}} could simplify the way we handle IN restrictions.
> The goal of this ticket is:
> * to refactor the {{Term}} and {{Terms}} interfaces to simplify the logic
> * Represents IN bind marker as {{Terms}} instead of having 2 different
> representations (a list of terms and a single {{MultiItemTerminal}}.
> * Simplify the {{AbstractMarker}} hierachy
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
