[
https://issues.apache.org/jira/browse/CASSANDRA-19414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17819831#comment-17819831
]
Ekaterina Dimitrova edited comment on CASSANDRA-19414 at 2/22/24 10:46 PM:
---------------------------------------------------------------------------
This patch suggests a -d flag to be added for generate.sh, which changes in
place the pre-commit workflow to the minimal config workflow seen
[here|https://app.circleci.com/pipelines/github/bereng/cassandra/1170/workflows/7707b811-6d4e-4cff-92de-9aff85d8ee03]
for JDK11 and
[here|https://app.circleci.com/pipelines/github/bereng/cassandra/1170/workflows/d76e0134-61e0-4c4d-95fe-a9e214c9d3ea]
for JDK 17.
* [~Bereng], I think changing the pre-commit workflow to the skinny one in
place is confusing. Shouldn't the flag generate a new workflow with a different
name? Like during_dev_tests or so? I can see how some people will start
cherry-picking config commits from others and use this config for pre-commit
because it also uses the same name, and then reviewers will have to make them
add the missing jobs. You will be surprised how many people use cherry-pick
instead of learning how generate.sh works and using it themselves. If people
learn there is a different workflow name, they will be at least cherry-picking
a different commit :D
* I do not see a cqlsh_dtests job? Even as one to be approved?
* Why only 5.0+? How about 4.0 and 4.1, which will still be maintained for
some time?
The rest is nits on the PR
was (Author: e.dimitrova):
This patch suggests a -d flag to be added for generate.sh, which changes in
place the pre-commit workflow to the minimal config workflow seen
[here|https://app.circleci.com/pipelines/github/bereng/cassandra/1170/workflows/7707b811-6d4e-4cff-92de-9aff85d8ee03]
for JDK11 and
[here|https://app.circleci.com/pipelines/github/bereng/cassandra/1170/workflows/d76e0134-61e0-4c4d-95fe-a9e214c9d3ea]
for JDK 17.
* [~Bereng], I think changing the pre-commit workflow to the skinny one in
place is confusing. Shouldn't the flag generate a new workflow with a different
name? Like during_dev_tests or so? I can see how some people will start
cherry-picking config commits from others and use this config for pre-commit
because it also uses the same name, and then reviewers will have to make them
add the missing jobs. You will be surprised how many people use cherry-pick
instead of learning how generate.sh works and using it themselves. If people
learn there is a different workflow name, they will be at least cherry-picking
a different commit :D
* I do not see a cqlsh_dtests job? Even as one to be approved?
The rest is nits on the PR
> Skinny dev circle workflow
> --------------------------
>
> Key: CASSANDRA-19414
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19414
> Project: Cassandra
> Issue Type: Improvement
> Components: CI
> Reporter: Berenguer Blasi
> Assignee: Berenguer Blasi
> Priority: Normal
> Fix For: 5.0.x, 5.x
>
>
> CircleCi CI runs are getting pretty heavy. During dev iterations we trigger
> many CI pre-commit jobs which are just an overkill.
> This ticket has the purpose to purge from the pre-commit workflow all
> variations of the test matrix but the vanilla one. That should enable us for
> a quick and cheap to iterate *during dev*, this is not a substitute for
> pre-commit . This ticket's work will serve as the basis for the upcoming
> changes being discussed
> [atm|https://lists.apache.org/thread/qf5c3hhz6qkpyqvbd3sppzlmftlc0bw0]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
