[
https://issues.apache.org/jira/browse/CASSANDRA-19414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17820126#comment-17820126
]
Ekaterina Dimitrova edited comment on CASSANDRA-19414 at 2/23/24 4:31 PM:
--------------------------------------------------------------------------
{quote} We discussed this offline iirc. Creating a new workflow would be great
but it means new configs throughout, a new workflow to maintain, etc.
{quote}
Indeed, we discussed that we won't add new workflows. We may add one behind the
new flag if we want to use it.
Here is what I suggest: I pushed a patch that changes the names of the
pre-commit workflows to during_dev when using -d. Thus, it will be easier for
people to differentiate workflows. Please check and let me know what you think.
The rest of the changes look good to me.
Patch:
[https://github.com/ekaterinadimitrova2/cassandra/commit/154a0ab6d59639f7aed441fd5abb9b747b5548e1]
This is what it looks like in CircleCI:
[https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=19406-5.0-proposal]
was (Author: e.dimitrova):
{quote} We discussed this offline iirc. Creating a new workflow would be great
but it means new configs throughout, a new workflow to maintain, etc.
{quote}
Indeed, we discussed that we won't add new workflows. We may add one behind the
new flag if we want to use it.
Here is what I suggest: I pushed a patch that changes the names of the
pre-commit workflows to during_dev when using -d. Thus, it will be easier for
people to differentiate workflows. Please check and let me know what you think.
The rest of your changes look good to me.
Patch:
https://github.com/ekaterinadimitrova2/cassandra/commit/154a0ab6d59639f7aed441fd5abb9b747b5548e1
This is what it looks like in CircleCI:
https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=19406-5.0-proposal
> Skinny dev circle workflow
> --------------------------
>
> Key: CASSANDRA-19414
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19414
> Project: Cassandra
> Issue Type: Improvement
> Components: CI
> Reporter: Berenguer Blasi
> Assignee: Berenguer Blasi
> Priority: Normal
> Fix For: 5.0.x, 5.x
>
>
> CircleCi CI runs are getting pretty heavy. During dev iterations we trigger
> many CI pre-commit jobs which are just an overkill.
> This ticket has the purpose to purge from the pre-commit workflow all
> variations of the test matrix but the vanilla one. That should enable us for
> a quick and cheap to iterate *during dev*, this is not a substitute for
> pre-commit . This ticket's work will serve as the basis for the upcoming
> changes being discussed
> [atm|https://lists.apache.org/thread/qf5c3hhz6qkpyqvbd3sppzlmftlc0bw0]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
