[
https://issues.apache.org/jira/browse/CASSANDRA-19428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17829658#comment-17829658
]
Ekaterina Dimitrova commented on CASSANDRA-19428:
-------------------------------------------------
The failing part turned out to be an edge case bug in Cassandra, which became
apparent after the refactoring. Fixed.
5.0 patch PR - https://github.com/apache/cassandra/pull/3194
Fully green CI -
[https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=19428-5.0-3]
I tested locally the patch on top of trunk - running the new fuzz tests added,
they all pass too.
I can propagate and run full CI when we confirm the final patch.
[~maedhroz] , can you review? Also, I will rely on your expertise to advise
whether to push this to 5.0 and trunk or only trunk. I am still learning that
area of the code.
Clean up KeyRangeIterator classes
* replace KeyRangeConcatIterator's PriorityQeueu with List
* remove KeyRangeIterator.current and simplify
* remove injected exception and tests - not relevant to the current
implementation
* expand randomized testing
* inline getCurrent() -> peek(); rename getCount to getMaxKeys
* redefine skipTo contract to not return a value (which saves unnecessary work
when skipTo is called multiple times in a row)
* calling hasNext in skipTo is a pessimization; if the iterator is in DONE
state, then skipTo will see it and avoid further effort; if it is not, then we
are computing a next value that we're just going to throw away
* Fix a bug in QueryController#getIndexResults error handling
> Clean up KeyRangeIterator classes
> ---------------------------------
>
> Key: CASSANDRA-19428
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19428
> Project: Cassandra
> Issue Type: Improvement
> Components: Feature/2i Index
> Reporter: Ekaterina Dimitrova
> Assignee: Ekaterina Dimitrova
> Priority: Low
> Fix For: 5.0.x, 5.x
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Remove KeyRangeIterator.current and simplify
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
