[
https://issues.apache.org/jira/browse/CASSANDRA-19556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17844790#comment-17844790
]
Stefan Miklosovic commented on CASSANDRA-19556:
-----------------------------------------------
[~yukei] I have created a PR against your branch which removes CASSANDRA-17495
and I refactored the tests little bit.
To speed up things a little bit, I have created 5.0 PR here. Based on the ML
link above, I think we need to remove CASSANDRA-17495 and incorporate these two
guardrails into that.
I think that we will work on 5.0 patch for now, I will take it from here if you
do not mind. Does this sound OK for you?
(1) https://github.com/Yukei7/cassandra/pull/1/files
(2) https://github.com/apache/cassandra/pull/3298
> Guardrail to block DDL/DCL queries
> ----------------------------------
>
> Key: CASSANDRA-19556
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19556
> Project: Cassandra
> Issue Type: New Feature
> Components: Feature/Guardrails
> Reporter: Yuqi Yan
> Assignee: Yuqi Yan
> Priority: Normal
> Fix For: 5.x
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Sometimes we want to block DDL/DCL queries to stop new schemas being created
> or roles created. (e.g. when doing live-upgrade)
> For DDL guardrail current implementation won't block the query if it's no-op
> (e.g. CREATE TABLE...IF NOT EXISTS, but table already exists, etc. The
> guardrail check is added in apply() right after all the existence check)
> I don't have preference on either block every DDL query or check whether if
> it's no-op here. Just we have some users always run CREATE..IF NOT EXISTS..
> at startup, which is no-op but will be blocked by this guardrail and failed
> to start.
>
> 4.1 PR: [https://github.com/apache/cassandra/pull/3248]
> trunk PR: [https://github.com/apache/cassandra/pull/3275]
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
